From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39391)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TkeOn-0005fd-Rz
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 12:22:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TkeOm-0006tK-PQ
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 12:22:41 -0500
Received: from cantor2.suse.de ([195.135.220.15]:39199 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TkeOm-0006mr-Iu
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 12:22:40 -0500
Message-ID: <50CF54AF.5070303@suse.de>
Date: Mon, 17 Dec 2012 18:21:51 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1355503606-54131-1-git-send-email-jfrei@linux.vnet.ibm.com>
	<1355503606-54131-3-git-send-email-jfrei@linux.vnet.ibm.com>
	<902FA814-A7AA-4BC2-9E84-4A7A9F5B1185@suse.de>
In-Reply-To: <902FA814-A7AA-4BC2-9E84-4A7A9F5B1185@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Heinz Graalfs <graalfs@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Christian Borntraeger <borntraeger@de.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Einar Lueck <elelueck@linux.vnet.ibm.com>

Am 17.12.2012 15:49, schrieb Alexander Graf:
>=20
> On 14.12.2012, at 17:46, Jens Freimann wrote:
>=20
>> @@ -37,12 +42,30 @@ static void s390_cpu_reset(CPUState *s)
>>         log_cpu_state(env, 0);
>>     }
>>
>> -    scc->parent_reset(s);
>> +    s390_del_running_cpu(env);
>>
>> +    scc->parent_reset(s);
>>     memset(env, 0, offsetof(CPUS390XState, breakpoints));
>=20
> Shouldn't parent_reset already do the memset?

No, because "env" location and size are specific to S390CPU.

And yes, it is ugly boilerplate code, but it cannot be solved with my
CPU_COMMON field movements alone (which partially add explicit reset
code based on the field location), there's quite a large number of
per-target fields that get reset that way, some intentionally, some
accidentally. ;-)

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg