From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH] spi: make sure all transfer has bits_per_word set Date: Mon, 17 Dec 2012 23:24:23 +0530 Message-ID: <50CF5C4F.5090609@nvidia.com> References: <1352452005-13789-1-git-send-email-ldewangan@nvidia.com> <20121206141507.86DCF3E0948@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Stephen Warren , Stephen Warren , "broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jonas Gorski , "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" To: Grant Likely Return-path: In-Reply-To: <20121206141507.86DCF3E0948@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thursday 06 December 2012 07:45 PM, Grant Likely wrote: > On Mon, 12 Nov 2012 11:03:56 +0100, Jonas Gorski wrote: >> Hi, >> >> On 9 November 2012 10:06, Laxman Dewangan wrote: >>> When spi client does the spi transfer and does not sets >>> the bits_per_word for each transfer then set it as default >>> of spi device in spi core before calling low level transfer. >> I like that (not that it counts ... )! >> >>> Removing the similar code from spi-tegra20-slink driver as >>> it is not required. >> Not sure if this should be part of *this* patch. >> Also spi-tegra20-slink isn't the only one fixing up the bits_per_word >> for transfers, so it would be nice if you could remove it from the >> other drivers, too. Just sent the patch to remove the similar code from most of driver. Tested only tegra driver. >> In a future patch, maybe even do the same with speed_hz? > That sounds reasonable. Could you craft one up and see how it looks? > > Ok, I will prepare change and send the patch. Thanks, Laxman ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752863Ab2LQRya (ORCPT ); Mon, 17 Dec 2012 12:54:30 -0500 Received: from hqemgate04.nvidia.com ([216.228.121.35]:11787 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917Ab2LQRy3 (ORCPT ); Mon, 17 Dec 2012 12:54:29 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 17 Dec 2012 09:52:10 -0800 Message-ID: <50CF5C4F.5090609@nvidia.com> Date: Mon, 17 Dec 2012 23:24:23 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Grant Likely CC: Jonas Gorski , "broonie@opensource.wolfsonmicro.com" , "spi-devel-general@lists.sourceforge.net" , Stephen Warren , "linux-kernel@vger.kernel.org" , Stephen Warren Subject: Re: [PATCH] spi: make sure all transfer has bits_per_word set References: <1352452005-13789-1-git-send-email-ldewangan@nvidia.com> <20121206141507.86DCF3E0948@localhost> In-Reply-To: <20121206141507.86DCF3E0948@localhost> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 06 December 2012 07:45 PM, Grant Likely wrote: > On Mon, 12 Nov 2012 11:03:56 +0100, Jonas Gorski wrote: >> Hi, >> >> On 9 November 2012 10:06, Laxman Dewangan wrote: >>> When spi client does the spi transfer and does not sets >>> the bits_per_word for each transfer then set it as default >>> of spi device in spi core before calling low level transfer. >> I like that (not that it counts ... )! >> >>> Removing the similar code from spi-tegra20-slink driver as >>> it is not required. >> Not sure if this should be part of *this* patch. >> Also spi-tegra20-slink isn't the only one fixing up the bits_per_word >> for transfers, so it would be nice if you could remove it from the >> other drivers, too. Just sent the patch to remove the similar code from most of driver. Tested only tegra driver. >> In a future patch, maybe even do the same with speed_hz? > That sounds reasonable. Could you craft one up and see how it looks? > > Ok, I will prepare change and send the patch. Thanks, Laxman