From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkiaS-00037y-BG for qemu-devel@nongnu.org; Mon, 17 Dec 2012 16:51:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkiaO-0007ee-BL for qemu-devel@nongnu.org; Mon, 17 Dec 2012 16:51:00 -0500 Message-ID: <50CF93B3.2090004@suse.de> Date: Mon, 17 Dec 2012 22:50:43 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1355753160-17544-1-git-send-email-armbru@redhat.com> <1355753160-17544-2-git-send-email-armbru@redhat.com> <6CCD7939-E75F-4EE1-A616-8BD90F4443B2@suse.de> <874njkrb7d.fsf@blackfin.pond.sub.org> In-Reply-To: <874njkrb7d.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, Peter Maydell , Alexander Graf , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Aurelien Jarno Am 17.12.2012 15:43, schrieb Markus Armbruster: > Alexander Graf writes: >=20 >> On 17.12.2012, at 15:05, Markus Armbruster wrote: >> >>> They complicate IDE data structures and keep getting in the way. >>> Also, TRIM support (commit d353fb72) is broken for them, because >>> ide_identify() accesses IDEDevice member conf, but IDEDevice exists >>> only with qdevified controllers. >>> >>> The non-qdevified controllers are still there, but attempting to >>> connect devices to them fails with "IDE controller not qdevified yet; >>> drive ignored". >>> >>> Affected machines: >>> >>> * g3beige's first IDE channel (MacIO) >>> -hda, -hdb are on first channel, and no longer work >>> -hdc, -hdd are on second channel, and still work >>> * mac99's second and third IDE channel (MacIO) >>> All four IDE drives no longer work >> >> Nack. This breaks the default targets of qemu-system-ppc and qemu-syst= em-ppc64. >=20 > Please tell us how much more time you want to qdevify IDE for these > targets. Thanks! I believe I have a branch with macio QOM'ifications somewhere that I could revive. Note that I know little about IDE or block layer and mainly care about consistent infrastructure there; I vaguely remember something about the mac's IDE channels being mixed together from two devices unlike real hardware, guess I would be unable to fix that. As for your question, 2013 and a gentle reminder to all involved would be nice. :) In particular we have the Soft Freeze coming up shortly after the holidays, so is this needed for 1.4 Soft Freeze or can it be deferred to 1.5 or done during the 1.4 Soft Freeze? If Aur=E9lien (CC'ed) doesn't manage, I can look at r2d as well. CC'ing Peter and Andrzej for the arm devices. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg