From: Jens Axboe <axboe@kernel.dk>
To: "Sam Bradshaw (sbradshaw)" <sbradshaw@micron.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
"Mike Berhan (mberhan)" <mberhan@micron.com>
Subject: Re: Latency spikes with 'thread' option
Date: Tue, 18 Dec 2012 09:29:05 +0100 [thread overview]
Message-ID: <50D02951.4030608@kernel.dk> (raw)
In-Reply-To: <50D01990.7080102@kernel.dk>
On 2012-12-18 08:21, Jens Axboe wrote:
> Good analysis and I believe you are correct. It's not safely shared and
> should be thread local. A quick test here with the below seems to
> indicate that that is indeed the issue, I don't see any time weirdness
> with that applied.
Bah, so that didn't work on all the supported platforms (notably OSX
does not have support for __thread). I've committed a patch that should
work across platforms, please give the current fio git a try (5d879392
or newer).
--
Jens Axboe
next prev parent reply other threads:[~2012-12-18 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 20:11 Latency spikes with 'thread' option Sam Bradshaw (sbradshaw)
2012-12-13 13:19 ` Jens Axboe
2012-12-17 22:23 ` Sam Bradshaw (sbradshaw)
2012-12-18 7:21 ` Jens Axboe
2012-12-18 8:29 ` Jens Axboe [this message]
2012-12-18 21:16 ` Sam Bradshaw (sbradshaw)
2012-12-19 7:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D02951.4030608@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=mberhan@micron.com \
--cc=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.