From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1.mentorg.com (relay1.mentorg.com [192.94.38.131]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 2DC2DE0073D for ; Tue, 18 Dec 2012 03:46:27 -0800 (PST) Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Tkvcw-0004r2-PR from Vladimir_Zapolskiy@mentor.com ; Tue, 18 Dec 2012 03:46:26 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 18 Dec 2012 03:46:26 -0800 Received: from [172.30.4.79] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.1.289.1; Tue, 18 Dec 2012 11:46:24 +0000 Message-ID: <50D05789.6040600@mentor.com> Date: Tue, 18 Dec 2012 13:46:17 +0200 From: Vladimir Zapolskiy User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.10) Gecko/20121028 Icedove/10.0.10 MIME-Version: 1.0 To: Otavio Salvador References: <1355787450-9831-1-git-send-email-vladimir_zapolskiy@mentor.com> In-Reply-To: X-Originating-IP: [137.202.0.76] X-OriginalArrivalTime: 18 Dec 2012 11:46:26.0112 (UTC) FILETIME=[4F7AEC00:01CDDD15] Cc: "meta-freescale@yoctoproject.org" Subject: Re: [PATCH] xf86-video-imxfb-vivante: add dependency on X11 X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2012 11:46:27 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 18.12.2012 13:10, Otavio Salvador wrote: > On Tue, Dec 18, 2012 at 8:30 AM, Andrei Gherzan wrote: >> On Tue, Dec 18, 2012 at 1:37 AM, Vladimir Zapolskiy >> wrote: >>> >>> Prior to xf86-video-imxfs-vivante there should be built libX11. >>> >>> This change fixes an issue met on configuration stage: >>> >>> | configure:3303: checking whether the C compiler works >>> | configure:3325: arm-mentor-linux-gnueabi-gcc -march=armv7-a >>> -mthumb-interwork -mfloat-abi=softfp -mfpu=neon -mtune=cortex-a9 >>> -mno-unaligned-access [snip] -lm -ldl -lGAL-x11 conftest.c>&5 >>> | >>> /opt/projects/mentor/thales-mel6.0/build/tmp/sysroots/imx6qsabrelite/usr/lib/libGAL-x11.so: >>> undefined reference to `XWidthOfScreen' >>> [snip] >>> | collect2: ld returned 1 exit status >> >> >> It's very strange that i never saw this issue before. I compiled this driver >> a couple of times and didn't see this error. Maybe it was a race thing where >> libx11 was compiled first but about that LDFLAGS, are you sure -lX11 is not >> added by default? >> >> +1 for [meta-fsl-arm] prefix. > > Andrei is right Vladimir. Please check if LDFLAGS is really need and > as Daiane said please bump PR. Daiane, Andrei, Otavio, thanks for comments, I'll send the second version of the patch for review. -- With best wishes, Vladimir