From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: alan@linux.intel.com, gregkh@linuxfoundation.org, jslaby@suse.cz,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-tegra@vger.kernel.org, wmb@firmworks.com
Subject: Re: [PATCH V2] serial: tegra: add serial driver
Date: Tue, 18 Dec 2012 09:49:27 -0700 [thread overview]
Message-ID: <50D09E97.5090805@wwwdotorg.org> (raw)
In-Reply-To: <1355813993-24867-1-git-send-email-ldewangan@nvidia.com>
On 12/17/2012 11:59 PM, Laxman Dewangan wrote:
> Nvidia's Tegra has multiple uart controller which supports:
A few nits:
That should be NVIDIA.
> .../devicetree/bindings/serial/serial-tegra.txt | 24 +
I strongly object to this name; I believe nvidia,tegra20-hsuart.txt is
correct.
> +NVIDIA Tegra20/Tegra30 high speed (dma based) UART controller driver.
DMA, UART (below), ... should be all capitals.
The binding looks reasonable to me. The few parts of the code I looked
at look OK.
> diff --git a/include/linux/platform_data/serial-tegra.h b/include/linux/platform_data/serial-tegra.h
> +#endif /* _SERIAL_TEGRA_H_ */
> +
There's a blank line at the end of the file.
prev parent reply other threads:[~2012-12-18 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 6:59 [PATCH V2] serial: tegra: add serial driver Laxman Dewangan
2012-12-18 6:59 ` Laxman Dewangan
[not found] ` <1355813993-24867-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-18 11:34 ` Alan Cox
2012-12-18 11:34 ` Alan Cox
2012-12-18 16:49 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D09E97.5090805@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alan@linux.intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=wmb@firmworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.