From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: Borislav Petkov <bp@alien8.de>, Jacob Shin <jacob.shin@amd.com>,
Doug Thompson <dougthompson@xmission.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MCE, AMD: MCE decoding support for AMD Family 16h
Date: Tue, 18 Dec 2012 17:00:09 -0200 [thread overview]
Message-ID: <50D0BD39.8030208@redhat.com> (raw)
In-Reply-To: <1355855866.30366.21.camel@joe-AO722>
Em 18-12-2012 16:37, Joe Perches escreveu:
> On Tue, 2012-12-18 at 19:33 +0100, Borislav Petkov wrote:
>> On Tue, Dec 18, 2012 at 10:24:29AM -0800, Joe Perches wrote:
>>> or without all the unnecessary parens and using char:
>>>
>>> pr_cont("%cBUFF parity error\n", xec == 4 ? 'I' : 'O');
>>
>> Char is fine, the parens make this more readable when you look at it
>> again after a couple of months :-).
>
> <shrug>
>
> I think the unnecessary parens make it _less_ readable
> because you need to parse more stuff and it's easy to
> misplace those parens.
I agree with Boris: the parenthesis at the test (xec == 4) makes it
easier to read, IMO.
Regards,
Mauro
next prev parent reply other threads:[~2012-12-18 19:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 19:39 [PATCH 1/2] MCE, AMD: Make MC2 decoding part of amd_decoder_ops as well Jacob Shin
2012-12-17 19:39 ` [PATCH 2/2] MCE, AMD: MCE decoding support for AMD Family 16h Jacob Shin
2012-12-18 17:19 ` Borislav Petkov
2012-12-18 17:30 ` Jacob Shin
2012-12-18 18:09 ` Jacob Shin
2012-12-18 18:32 ` Borislav Petkov
2012-12-18 18:24 ` Joe Perches
2012-12-18 18:33 ` Borislav Petkov
2012-12-18 18:37 ` Joe Perches
2012-12-18 19:00 ` Mauro Carvalho Chehab [this message]
2012-12-17 19:57 ` [PATCH 1/2] MCE, AMD: Make MC2 decoding part of amd_decoder_ops as well Joe Perches
2012-12-17 20:05 ` Borislav Petkov
2012-12-17 20:16 ` Joe Perches
2012-12-17 20:22 ` Borislav Petkov
2012-12-17 20:34 ` Joe Perches
2012-12-17 20:40 ` Borislav Petkov
2012-12-17 20:43 ` Jacob Shin
2012-12-17 20:59 ` Joe Perches
2012-12-17 21:08 ` Borislav Petkov
2012-12-17 21:11 ` Jacob Shin
2012-12-17 21:09 ` Jacob Shin
-- strict thread matches above, loose matches on Subject: below --
2012-12-18 21:06 [PATCH V2 0/2] MCE, AMD: MCE decoding support for AMD Family 16h Jacob Shin
2012-12-18 21:06 ` [PATCH 2/2] " Jacob Shin
2012-12-18 22:10 ` Joe Perches
2012-12-18 22:56 ` Borislav Petkov
2012-12-20 19:20 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D0BD39.8030208@redhat.com \
--to=mchehab@redhat.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=jacob.shin@amd.com \
--cc=joe@perches.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.