From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl3LI-0004Ie-6f for qemu-devel@nongnu.org; Tue, 18 Dec 2012 15:00:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tl3LG-0008UD-K5 for qemu-devel@nongnu.org; Tue, 18 Dec 2012 15:00:44 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58226 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl3LG-0008Tv-6R for qemu-devel@nongnu.org; Tue, 18 Dec 2012 15:00:42 -0500 Message-ID: <50D0CB59.1020509@suse.de> Date: Tue, 18 Dec 2012 21:00:25 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1355817223-13076-1-git-send-email-afaerber@suse.de> <1355817223-13076-2-git-send-email-afaerber@suse.de> <20121218174249.GH5334@otherpad.lan.raisama.net> In-Reply-To: <20121218174249.GH5334@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Peter Maydell , Richard Henderson , qemu-devel@nongnu.org, David Gibson , Paul Brook Am 18.12.2012 18:42, schrieb Eduardo Habkost: > On Tue, Dec 18, 2012 at 08:53:40AM +0100, Andreas F=E4rber wrote: >> diff --git a/include/qemu/cpu.h b/include/qemu/cpu.h >> index 61b7698..5fbb3f9 100644 >> --- a/include/qemu/cpu.h >> +++ b/include/qemu/cpu.h >> @@ -21,6 +21,7 @@ >> #define QEMU_CPU_H >> =20 >> #include "qemu/object.h" >> +#include "qemu-common.h" >> #include "qemu-thread.h" >=20 > Please, don't add more "#include qemu-common.h" lines to header files. > This introduces yet another circular dependency: >=20 > qemu-common.h -> target-*/cpu.h -> target-*/cpu-qom.h -> qemu/cpu.h -> = qemu-common.h That's what 2/4 resolves. My reasoning was that this should be an uncontroversial code-sharing change since, for good or bad, qemu-common.h happens to be the place where this is defined today. Whether to move it to qemu-types.h as proposed or to a new qemu-stdio.h affects more than just the core CPU and thus me as maintainer and requires careful mingw32 etc. testing. > You could just reverse the order of patches 1/4 and 2/4, and include > "qemu-types.h" instead. If we find an agreeable solution by tomorrow for how/where to do it, sure= ! Andreas > The rest of the patch is an obvious removal of duplicate code, that > would get a Reviewed-By line from me. --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg