From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41429)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tl698-0004M5-L1
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 18:00:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tl696-000741-CT
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 18:00:21 -0500
Received: from cantor2.suse.de ([195.135.220.15]:34571 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tl696-00073k-5m
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 18:00:20 -0500
Message-ID: <50D0F579.6060106@suse.de>
Date: Wed, 19 Dec 2012 00:00:09 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1355017216-22962-1-git-send-email-afaerber@suse.de>
	<1355017216-22962-5-git-send-email-afaerber@suse.de>
In-Reply-To: <1355017216-22962-5-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 4/5] target-alpha: Turn CPU
 definitions into subclasses
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>

Am 09.12.2012 02:40, schrieb Andreas F=C3=A4rber:
> Make TYPE_ALPHA_CPU abstract and add types <name>-alpha-cpu.
> Use type inheritence, and turn "2*" models into aliases.
>=20
> Move cpu_alpha_init() to cpu.c and split out CPU realization.
> Default to creating type "ev67-alpha-cpu" as before.
>=20
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-alpha/cpu.c       |  178 ++++++++++++++++++++++++++++++++++++++=
+++++++-
>  target-alpha/cpu.h       |    2 +
>  target-alpha/translate.c |   58 +--------------
>  3 Dateien ge=C3=A4ndert, 180 Zeilen hinzugef=C3=BCgt(+), 58 Zeilen ent=
fernt(-)
>=20
> diff --git a/target-alpha/cpu.c b/target-alpha/cpu.c
> index 11a19eb..11df753 100644
> --- a/target-alpha/cpu.c
> +++ b/target-alpha/cpu.c
> @@ -21,8 +21,175 @@
> =20
>  #include "cpu.h"
>  #include "qemu-common.h"
> +#include "error.h"
> =20
> =20
> +static void alpha_cpu_realize(Object *obj, Error **err)

Should've been errp by convention, fixed.
No functional change since unused.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg