All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/3] slang: added gnu-configize for AArch64 support
Date: Wed, 19 Dec 2012 00:49:58 +0100	[thread overview]
Message-ID: <50D10126.5080600@linaro.org> (raw)
In-Reply-To: <CAJTo0LZDZjg3fycmeUdgHpkxQJBd3BQXiaSEB1hwJDE7NRO-yw@mail.gmail.com>

W dniu 18.12.2012 20:56, Burton, Ross pisze:
> On 18 December 2012 19:17, Saul Wold <sgw@linux.intel.com> wrote:
>>> +do_configure_prepend() {
>>> +    # slang keeps configure.ac and rest of autoconf files in autoconf/
>>> directory
>>> +    # we have to go there to be able to run gnu-configize cause it
>>> expects configure.{in,ac}
>>> +    # to be present. Resulting files land in autoconf/autoconf/ so we
>>> need to move them.
>>> +    cd ${S}/autoconf && gnu-configize --force && mv autoconf/config.* .
>>> +    cd ${S}
>>> +}
>>
>> Should these be ${S} or ${B} (or some combination), I believe we are trying
>> to allow for builds to be in a different dir where ${S} != ${B}?
> 
> Yes, I would like people to consider $S and $B when writing things
> like this - whilst at the moment it's a disaster to attempt S!=B, I've
> a branch (ross/bnots on poky-contrib) where I'm fixing/disabling the
> problem recipes.
> 
> I this case, $S then $B should be right, afaik.

The problem is that $S == $B in this case so hard to check which is
proper (for me). I would love to use pushd/popd but they are bashisms iirc.



  reply	other threads:[~2012-12-19  0:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18  9:03 [PATCH 1/3] xinetd: added gnu-configize for AArch64 support Marcin Juszkiewicz
2012-12-18  9:03 ` [PATCH 2/3] slang: " Marcin Juszkiewicz
2012-12-18 19:17   ` Saul Wold
2012-12-18 19:56     ` Burton, Ross
2012-12-18 23:49       ` Marcin Juszkiewicz [this message]
2012-12-20 10:50       ` [PATCH] " Marcin Juszkiewicz
2012-12-18  9:03 ` [PATCH 3/3] net-tools: disable Token Ring and Strip support - both got removed in 3.7 kernel Marcin Juszkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D10126.5080600@linaro.org \
    --to=marcin.juszkiewicz@linaro.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.