From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752271Ab2LSH1j (ORCPT ); Wed, 19 Dec 2012 02:27:39 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:47987 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221Ab2LSH1d (ORCPT ); Wed, 19 Dec 2012 02:27:33 -0500 X-Greylist: delayed 362 seconds by postgrey-1.27 at vger.kernel.org; Wed, 19 Dec 2012 02:27:33 EST Message-ID: <50D16AF8.7030401@vflare.org> Date: Tue, 18 Dec 2012 23:21:28 -0800 From: Nitin Gupta User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Greg KH CC: Jerome Marchand , Minchan Kim , Seth Jennings , Konrad Rzeszutek Wilk , Dan Carpenter , Sam Hansen , Linux Driver Project , linux-kernel , stable@vger.kernel.org Subject: Re: zram: fix invalid memory references during disk write References: <1354257909-2380-1-git-send-email-ngupta@vflare.org> <20121211182720.GC29421@kroah.com> <20121219034949.GA22281@kroah.com> In-Reply-To: <20121219034949.GA22281@kroah.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/18/2012 07:49 PM, Greg KH wrote: > On Tue, Dec 18, 2012 at 01:12:05PM -0800, Nitin Gupta wrote: >> On Tue, Dec 11, 2012 at 10:27 AM, Greg KH wrote: >>> On Thu, Nov 29, 2012 at 10:45:09PM -0800, Nitin Gupta wrote: >>>> Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling >>>> of incompressible pages") which caused invalid memory references >>>> during disk write. Invalid references could occur in two cases: >>>> - Incoming data expands on compression: In this case, reference was >>>> made to kunmap()'ed bio page. >>>> - Partial (non PAGE_SIZE) write with incompressible data: In this >>>> case, reference was made to a kfree()'ed buffer. >>>> >>>> Fixes bug 50081: >>>> https://bugzilla.kernel.org/show_bug.cgi?id=50081 >>>> >>>> Upstream commit ID: c8f2f0d: zram: Fix handling of incompressible pages >>>> Apply to versions: 3.6.5, 3.6.6, 3.6.7, 3.6.8 >>>> >>>> Cc: # staging-next: 37b51fd: zram: factor-out >>>> # zram_decompress_page() function >>>> Signed-off-by: Nitin Gupta >>>> Reported-by: Mihail Kasadjikov >>>> Reported-by: Tomas M >>>> Reviewed-by: Minchan Kim >>>> --- >>>> drivers/staging/zram/zram_drv.c | 39 ++++++++++++++++++++++++--------------- >>>> 1 file changed, 24 insertions(+), 15 deletions(-) >>> >>> This patch fails to apply to 3.6.10: >>> >>> patching file drivers/staging/zram/zram_drv.c >>> Hunk #1 succeeded at 282 (offset 17 lines). >>> Hunk #2 FAILED at 286. >>> Hunk #3 succeeded at 319 (offset 17 lines). >>> Hunk #4 succeeded at 340 (offset 17 lines). >>> Hunk #5 succeeded at 353 (offset 17 lines). >>> Hunk #6 succeeded at 368 (offset 17 lines). >>> Hunk #7 succeeded at 385 (offset 17 lines). >>> 1 out of 7 hunks FAILED -- saving rejects to file drivers/staging/zram/zram_drv.c.rej >>> >>> Please redo this patch and resend it if you wish for it to be applied to >>> the 3.6-stable tree. >>> >>> >> >> Please apply this patch to stable tree asap. > > 3.6 is now end-of-life, there will not be any more releases for that > kernel series anymore, sorry. > Then please apply to 3.7. Nitin