From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Henningsson Subject: Re: [PATCH] Revert "ALSA: hda - Shut up pins at power-saving mode with Conexnat codecs" Date: Wed, 19 Dec 2012 11:34:46 +0100 Message-ID: <50D19846.8060902@canonical.com> References: <1355906687-2881-1-git-send-email-david.henningsson@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by alsa0.perex.cz (Postfix) with ESMTP id 4A745264F0F for ; Wed, 19 Dec 2012 11:34:47 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, 886975@bugs.launchpad.net List-Id: alsa-devel@alsa-project.org On 12/19/2012 11:24 AM, Takashi Iwai wrote: > At Wed, 19 Dec 2012 09:44:47 +0100, > David Henningsson wrote: >> >> This reverts commit 697c373e34613609cb5450f98b91fefb6e910588. >> >> The original patch was meant to remove clicking, but in fact caused even >> more clicking instead. >> >> Thanks to c4pp4 for doing most of the work with this bug. >> >> BugLink: https://bugs.launchpad.net/bugs/886975 >> Signed-off-by: David Henningsson >> --- >> >> @c4pp4: Is this consistent with what you have done to reduce the clicking? >> Will you recommend upstream Linux to take the patch below? > > So, it shouldn't be merged yet right now? > Now is the last chance for merging it to 3.8-rc1. If we don't have time waiting for c4pp4's confirmation without missing the entire 3.8 cycle, then I think we should merge it. -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic