From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <50D1EA28.2000807@wwwdotorg.org> Date: Wed, 19 Dec 2012 09:24:08 -0700 From: Stephen Warren MIME-Version: 1.0 To: Grant Likely Subject: Re: [PATCH] of: Fix export of of_find_matching_node_and_match() References: <1355914716-19469-1-git-send-email-grant.likely@secretlab.ca> In-Reply-To: <1355914716-19469-1-git-send-email-grant.likely@secretlab.ca> Content-Type: text/plain; charset=ISO-8859-1 Cc: Stephen Warren , devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/19/2012 03:58 AM, Grant Likely wrote: > Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > renamed of_find_matching_node() to of_find_matching_node_and_match() and > created a new static inline of_find_matching_node() wrapper around the > new name. However, the change neglected to change the EXPORT_SYMBOL() > reference causing build errors for modules. > > This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > Efika build with the mpc52xx_uart driver being built as a module. Oops. The patch is obviously correct, Reviewed-by: Stephen Warren I guess none of the ARM defconfigs enable any module that uses this, since I have built all of them multiple times recently:-( From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] of: Fix export of of_find_matching_node_and_match() Date: Wed, 19 Dec 2012 09:24:08 -0700 Message-ID: <50D1EA28.2000807@wwwdotorg.org> References: <1355914716-19469-1-git-send-email-grant.likely@secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1355914716-19469-1-git-send-email-grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Grant Likely Cc: Stephen Warren , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring List-Id: devicetree@vger.kernel.org On 12/19/2012 03:58 AM, Grant Likely wrote: > Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > renamed of_find_matching_node() to of_find_matching_node_and_match() and > created a new static inline of_find_matching_node() wrapper around the > new name. However, the change neglected to change the EXPORT_SYMBOL() > reference causing build errors for modules. > > This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > Efika build with the mpc52xx_uart driver being built as a module. Oops. The patch is obviously correct, Reviewed-by: Stephen Warren I guess none of the ARM defconfigs enable any module that uses this, since I have built all of them multiple times recently:-( From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508Ab2LSQYT (ORCPT ); Wed, 19 Dec 2012 11:24:19 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:48176 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810Ab2LSQYN (ORCPT ); Wed, 19 Dec 2012 11:24:13 -0500 Message-ID: <50D1EA28.2000807@wwwdotorg.org> Date: Wed, 19 Dec 2012 09:24:08 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Grant Likely CC: linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, Stephen Warren , Rob Herring Subject: Re: [PATCH] of: Fix export of of_find_matching_node_and_match() References: <1355914716-19469-1-git-send-email-grant.likely@secretlab.ca> In-Reply-To: <1355914716-19469-1-git-send-email-grant.likely@secretlab.ca> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/19/2012 03:58 AM, Grant Likely wrote: > Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > renamed of_find_matching_node() to of_find_matching_node_and_match() and > created a new static inline of_find_matching_node() wrapper around the > new name. However, the change neglected to change the EXPORT_SYMBOL() > reference causing build errors for modules. > > This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > Efika build with the mpc52xx_uart driver being built as a module. Oops. The patch is obviously correct, Reviewed-by: Stephen Warren I guess none of the ARM defconfigs enable any module that uses this, since I have built all of them multiple times recently:-(