Re: [Qemu-devel] [PATCH 8/9] chardev: hotplug, qmp, serial

[Gerd Hoffmann <kraxel@redhat.com>]

On 12/19/12 17:21, Paolo Bonzini wrote:
> Il 19/12/2012 16:59, Gerd Hoffmann ha scritto:
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>>  qapi-schema.json |    3 ++-
>>  qemu-char.c      |   16 ++++++++++++++--
>>  2 files changed, 16 insertions(+), 3 deletions(-)
>>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 7e5c8c2..d833385 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -3036,7 +3036,8 @@
>>  { 'type': 'ChardevFile', 'data': { '*in' : 'ChardevFileSource',
>>                                     'out' : 'ChardevFileSource' } }
>>  
>> -{ 'enum': 'ChardevPortKind', 'data': [ 'tty' ] }
>> +{ 'enum': 'ChardevPortKind', 'data': [ 'tty',
>> +                                       'serial' ] }
> 
> I think 'tty' and 'serial' are really the same thing, just one for
> Windows and one for Linux.

Partly disagree.

tty is a very unix-ish concept, having that on windows would be
confusing I think.

serial lines happen to be a subset of tty on linux.  The patch aliases
serial to tty on unix because of that.

> We could make one a synonym of the other, even for -chardev.

Makes sense to be consistent here.

cheers,
  Gerd