From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] gdbus: Fix double free when calling g_dbus_remove_all_watches
Date: Thu, 20 Dec 2012 09:46:32 +0200 [thread overview]
Message-ID: <50D2C258.4000908@linux.intel.com> (raw)
In-Reply-To: <CAMOw1v40+w62ToR4SKnNLnKfLzBSz_MKK1fXwoW66z7cXbTw4A@mail.gmail.com>
Hi Lucas,
> @@ -309,6 +309,9 @@ static void filter_data_call_and_free(struct filter_data *data)
> g_free(cb);
> }
>
> + g_slist_free(data->callbacks);
> + data->callbacks = NULL;
> +
>
> why not just removing the g_free(cb) above?
>
I did so to avoid filter_data_free() to go through the list once again,
but indeed if the list is not going to be big, it's superfluous then.
Tomasz
next prev parent reply other threads:[~2012-12-20 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 10:09 [PATCH BlueZ] gdbus: Fix crash error when calling g_dbus_remove_all_watches Tomasz Bursztyka
2012-11-28 12:23 ` Johan Hedberg
2012-12-17 11:33 ` Tomasz Bursztyka
2012-12-19 12:01 ` [PATCH] gdbus: Fix double free " Tomasz Bursztyka
2012-12-19 17:50 ` Lucas De Marchi
2012-12-20 7:46 ` Tomasz Bursztyka [this message]
2012-12-20 14:48 ` Authentication issue during connection if remote deletes link key Jaganath Kanakkassery
2012-12-20 15:33 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D2C258.4000908@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.