From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eunchul Kim Subject: Re: [PATCH 3/8] drm/exynos: fixed vflip, hflip case at the same time. Date: Thu, 20 Dec 2012 19:15:43 +0900 Message-ID: <50D2E54F.3040901@samsung.com> References: <1355995895-16355-1-git-send-email-chulspro.kim@samsung.com> <1355995895-16355-4-git-send-email-chulspro.kim@samsung.com> <03e201cdde97$32dc0380$98940a80$%dae@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id B2979E5EF2 for ; Thu, 20 Dec 2012 02:15:24 -0800 (PST) Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MFB005WFR59ZRW0@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 20 Dec 2012 19:15:22 +0900 (KST) Received: from [10.90.54.32] by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MFB004L7R5LVA90@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 20 Dec 2012 19:15:22 +0900 (KST) In-reply-to: <03e201cdde97$32dc0380$98940a80$%dae@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Inki Dae Cc: jy0.jeon@samsung.com, sw0312.kim@samsung.com, jaejoon.seo@samsung.com, kyungmin.park@samsung.com, dri-devel@lists.freedesktop.org, lsmin.lee@samsung.com, th908.kim@samsung.com, jmock.shin@samsung.com List-Id: dri-devel@lists.freedesktop.org Thank's for comment. Oops, sorry that is my fault. I will resend it. BR Eunchul Kim On 12/20/2012 06:48 PM, Inki Dae wrote: > > >> -----Original Message----- >> From: Eunchul Kim [mailto:chulspro.kim@samsung.com] >> Sent: Thursday, December 20, 2012 6:32 PM >> To: dri-devel@lists.freedesktop.org; inki.dae@samsung.com >> Cc: jy0.jeon@samsung.com; yj44.cho@samsung.com; jmock.shin@samsung.com; >> jaejoon.seo@samsung.com; kyungmin.park@samsung.com; >> jy0922.shim@samsung.com; sw0312.kim@samsung.com; th908.kim@samsung.com; >> lsmin.lee@samsung.com; chulspro.kim@samsung.com >> Subject: [PATCH 3/8] drm/exynos: fixed vflip, hflip case at the same time. >> >> This patch fixed vflip, hflip at the same time. If we want to change 180 >> degree about buffer, >> then we can use h,vflip or 180 degree. we supports 180 degree using >> h,vflip. >> but we make error handling in this case. so, fixed it. >> >> Signed-off-by: Eunchul Kim >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 + >> drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 + >> 2 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c >> b/drivers/gpu/drm/exynos/exynos_drm_fimc.c >> index 5dc0251..4c4078c 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c >> @@ -1387,6 +1387,7 @@ static inline bool fimc_check_drm_flip(enum >> drm_exynos_flip flip) >> case EXYNOS_DRM_FLIP_NONE: >> case EXYNOS_DRM_FLIP_VERTICAL: >> case EXYNOS_DRM_FLIP_HORIZONTAL: >> + case EXYNOS_DRM_FLIP_VERTICAL | EXYNOS_DRM_FLIP_HORIZONTAL: > > This code induces build warning because the value of 'VERTICAL | HORIZONTAL' > is out of range. Add a new enumeration value to enum drm_exynos_flip. i.e. > EXYNOS_DRM_FLIP_BOTH = EXYNOS_DRM_FLIP_VERTICAL | EXYNOS_DRM_FLIP_HORIZONTAL > and use it. - thank's I guess why not occured warnning. but It's the better. I will resend it. > >> return true; >> default: >> DRM_DEBUG_KMS("%s:invalid flip\n", __func__); >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c >> b/drivers/gpu/drm/exynos/exynos_drm_rotator.c >> index 17e4474..09830ad 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c >> @@ -513,6 +513,7 @@ static inline bool rotator_check_drm_flip(enum >> drm_exynos_flip flip) >> case EXYNOS_DRM_FLIP_NONE: >> case EXYNOS_DRM_FLIP_VERTICAL: >> case EXYNOS_DRM_FLIP_HORIZONTAL: >> + case EXYNOS_DRM_FLIP_VERTICAL | EXYNOS_DRM_FLIP_HORIZONTAL: > > Ditto. > >> return true; >> default: >> DRM_DEBUG_KMS("%s:invalid flip\n", __func__); >> -- >> 1.7.0.4 > >