From: Radu Moisan <radu.moisan@intel.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: RFC: systemd integration
Date: Thu, 20 Dec 2012 13:30:28 +0200 [thread overview]
Message-ID: <50D2F6D4.5080001@intel.com> (raw)
In-Reply-To: <20121220104241.GG14543@jama.palm1.palmone.com>
On 12/20/2012 12:42 PM, Martin Jansa wrote:
> On Wed, Dec 19, 2012 at 07:20:45PM +0200, Radu Moisan wrote:
>> Hi guys,
>> I have prepared a branch on poky-contrib (rmoisan/systemd) where I
>> pulled systemd from meta-openembedded. The goal is to merge this into
>> oe-core, so please take a look and give me your feedback on stuff that
>> needs work or things that I might have done wrong, so that I can prepare
>> it for merge.
>> At this point core-image-minimal and core-image-sato both boot fine
>> with systemd. There still are a few warnings but not critical(at
>> runtime), at least in my opinion, you may want to take a look at those too.
>> You can activate systemd by *DISTRO_FEATURES_INITMAN = "systemd"*
> What about upgrade path from meta-systemd?
>
> I've noticed that
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/meta/recipes-connectivity/wpa-supplicant?h=rmoisan/systemd&id=02f4027f7ccddaff3b0316962e7a86a04d31abbc
> does not increment PR at all while
> http://git.openembedded.org/meta-openembedded/tree/meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_1.0.bbappend
> PRINC := "${@int(PRINC) + 2}"
I'll take care of this one.
>
> Also I like this commit very much
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/meta/recipes-connectivity/wpa-supplicant?h=rmoisan/systemd&id=216049b154799fc7984c54858a386d7318f99ce0
> but current styleguide thinks something else about consistent whitespace
> usage. So I think this wont be accepted as my change to styleguide
> wasn't.
I think Richard suggested it, but anyway wasn't the recomandation to use
spaces instead of tabs (I use 4 spaces)? I can revert or change it when
time comes. Feedback on this will be well appreciated.
> And last thing:
> there is few pending patches for meta-systemd:
> http://patchwork.openembedded.org/project/oe/list/?q=systemd
> Can you check them and merge them if needed? Or will you update your
> systemd* copies if we merge them in meta-oe?
These look very interesting. I'll take a closer look and pull them in as
appropriate.
Radu
next prev parent reply other threads:[~2012-12-20 11:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 17:20 RFC: systemd integration Radu Moisan
2012-12-19 17:21 ` Otavio Salvador
2012-12-19 20:55 ` Eric Bénard
2012-12-20 8:55 ` Radu Moisan
2012-12-19 20:57 ` Eric Bénard
2012-12-20 8:52 ` Radu Moisan
2012-12-20 10:08 ` Radu Moisan
2012-12-20 9:00 ` Yi Qingliang
2012-12-20 10:42 ` Martin Jansa
2012-12-20 11:30 ` Radu Moisan [this message]
2012-12-20 10:47 ` Koen Kooi
2012-12-20 11:25 ` Radu Moisan
2012-12-20 12:39 ` Burton, Ross
2012-12-20 12:50 ` Otavio Salvador
2012-12-20 12:59 ` Burton, Ross
2012-12-20 13:09 ` Otavio Salvador
2012-12-20 14:31 ` Burton, Ross
2012-12-20 15:20 ` Otavio Salvador
2012-12-26 10:58 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D2F6D4.5080001@intel.com \
--to=radu.moisan@intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.