From: Wolfgang Grandegger <wg@grandegger.com>
To: Amit Virdi <amit.virdi@st.com>
Cc: Bhupesh SHARMA <bhupesh.sharma@st.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"mkl@pengutronix.de" <mkl@pengutronix.de>,
"anilkumar@ti.com" <anilkumar@ti.com>,
spear-devel <spear-devel@list.st.com>
Subject: Re: [PATCH 2/3] can: c_can: Provide generic interface to configure c-can message objects
Date: Thu, 20 Dec 2012 13:20:53 +0100 [thread overview]
Message-ID: <50D302A5.30706@grandegger.com> (raw)
In-Reply-To: <50D2F3F0.7040509@st.com>
On 12/20/2012 12:18 PM, Amit Virdi wrote:
> On 12/20/2012 4:42 PM, Wolfgang Grandegger wrote:
>>> I believe this is a good feature to keep, otherwise we always have
>>> the default option of
>>> > having equal msg objects for Tx and Rx purposes (16 each).
>> We need to improve the RX handling anyway similar to Marc's at91_can
>> driver. There 24 objects are used for RX and 8 for TX.
>
> Ok but maybe for the time being we can go ahead with this
> implementation. When Marc's helper library is ready, we can send patches
> over the current implementation to adapt to it.
This TX handing improvement does not block this patch. The question is
also if the device-tree is the right place for such variables. If they
should be configurable by the user, the device-tree is too static (apart
from the fact that it's not a hardware property). A normal user cannot
change the device-tree.
Wolfgang.
next prev parent reply other threads:[~2012-12-20 12:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 10:05 [PATCH 0/3] c_can: Update can support Amit Virdi
2012-12-20 10:05 ` [PATCH 1/3] can: c_can: Correct register alignment info passing through DT Amit Virdi
2012-12-20 13:59 ` Marc Kleine-Budde
2013-01-16 7:40 ` Amit Virdi
2012-12-20 10:05 ` [PATCH 2/3] can: c_can: Provide generic interface to configure c-can message objects Amit Virdi
2012-12-20 10:26 ` Wolfgang Grandegger
2012-12-20 10:53 ` Amit Virdi
2012-12-20 11:06 ` Bhupesh SHARMA
2012-12-20 11:12 ` Wolfgang Grandegger
2012-12-20 11:18 ` Amit Virdi
2012-12-20 12:20 ` Wolfgang Grandegger [this message]
2012-12-20 14:04 ` Marc Kleine-Budde
2012-12-20 20:13 ` Wolfgang Grandegger
2013-01-16 7:45 ` Amit Virdi
2013-01-16 8:25 ` Bhupesh SHARMA
2013-01-16 9:01 ` Wolfgang Grandegger
2013-01-16 9:03 ` Wolfgang Grandegger
2013-01-16 9:11 ` Amit Virdi
2012-12-20 10:05 ` [PATCH 3/3] can: c_can: Enable clock before first use Amit Virdi
2012-12-20 14:07 ` Marc Kleine-Budde
2013-01-16 8:03 ` Amit Virdi
2013-01-16 9:54 ` AnilKumar, Chimata
2013-01-16 9:54 ` AnilKumar, Chimata
2013-01-16 13:53 ` Rafael J. Wysocki
2013-01-16 13:53 ` Rafael J. Wysocki
2012-12-20 13:57 ` [PATCH 0/3] c_can: Update can support Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D302A5.30706@grandegger.com \
--to=wg@grandegger.com \
--cc=amit.virdi@st.com \
--cc=anilkumar@ti.com \
--cc=bhupesh.sharma@st.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=spear-devel@list.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.