Re: [PATCH 4/5] yocto-layer: add 'layer' template data

[Gary Thomas <gary@mlbassoc.com>]

On 2012-12-20 09:23, Tom Zanussi wrote:
> On Wed, 2012-12-19 at 16:40 -0800, Darren Hart wrote:
>>
>> On 12/17/2012 09:51 AM, tom.zanussi@intel.com wrote:
>>> From: Tom Zanussi <tom.zanussi@intel.com>
>>>
>>> Add a 'layer' target containing all the data that will be used to
>>> generate a generic yocto layer.
>>>
>>> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
>>> ---
>>
>> Great stuff Tom, only one nit below:
>>
>>> new file mode 100644
>>> index 0000000..90ce90e
>>> --- /dev/null
>>> +++ "b/scripts/lib/bsp/substrate/target/arch/layer/{{ if create_example_recipe == \"y\": }} recipes-example/example/{{=example_recipe_name}}-0.1/helloworld.c"	
>>> @@ -0,0 +1,6 @@
>>> +#include <stdio.h>
>>> +
>>> +int main(int argc, char **argv)
>>> +{
>>> +    printf("Hello World!\n");
>>
>> If you specify a return type of int, you should be returning one:
>>
>> 	return 0;
>>
>> :-)
>>
>
> Hmm, I don't think that's actually necessary for main() - if you don't
> specify a return value for main(), it should already implicitly return 0
> IIRC...

Not true - that would be compiler specific and should not be relied on.
Always best to be explicit (plus it will eliminate a GCC warning!)

>
> Tom
>
>>> +}
>>
>>
>> Looks good otherwise.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------