From mboxrd@z Thu Jan 1 00:00:00 1970 From: dom Subject: Re: [PATCH 0/2] Add V4V to Xen (v8) Date: Thu, 20 Dec 2012 10:14:34 -0800 Message-ID: <50D3558A.1090105@citrix.com> References: <1351187729-4681-1-git-send-email-jean.guyader@citrix.com> <508E5C6B02000078000A5011@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <508E5C6B02000078000A5011@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: "Tim (Xen.org)" , "Jean Guyader (3P)" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 10/29/2012 02:37 AM, Jan Beulich wrote: >>>> On 25.10.12 at 19:55, Jean Guyader wrote: >> v8 changes: >> - Move v4v private structures to v4v.c >> - fix padding > I still spotted at least one bogus padding field (in struct > v4v_ring_message_header, where no field is more than 4-byte > aligned afaict). Did you really carefully walk through all of them? Hi Jan, I am going to try and pilot this home, as I believe JeanG will not. I just had a couple of questions about your comments that I hope you could help me with. > Also, to validate the structures are really compatible between > native and compat mode guests, I'd strongly recommend adding > the leaf ones to xen/include/xlat.lst. I'm sorry I don't understand. What is xlat.lst ? And how does it help ? > Further I don't think you sync-ed up your patches with the > XEN_GUEST_HANDLE_PARAM() changes done for ARM, yet you > also didn't mention that the patch set is against other than the > tip of unstable. Sorry, again I'm confused. I thought all the Xen ARM changes went into xen-unstable. What other branches/trees do you think I need to post the v4v patch set against ? > > There appear to be plenty left (space between function name and > opening parenthesis, indentation inside switch statement, missing > parenthesization of macro expansion, missing newline between > declarations and statements are which I noticed without specifically > looking for them). > > OK. This I can do. dom