All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya <chaitanyatk@posedge.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] mac80211: Fix the MAX MTU calculation
Date: Fri, 21 Dec 2012 17:15:17 +0530	[thread overview]
Message-ID: <50D44BCC.30304@posedge.com> (raw)
In-Reply-To: <201212211141.qBLBfZdq015078@chaitanya-desktop>


Fix the Max MTU calculations.
Do not take headers in to account, only MAX MSDU size
as per 802.11-2012(8.2.3) is enough.

ToDo: Add support for AMSDU in future.

Signed-off-by: T Krishna Chaitanya <chaitanyatk@posedge.com>
---

 net/mac80211/iface.c |   23 ++++++++++++++++-------
 1 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 54fb7f9..5e5e876 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -207,15 +207,24 @@ void ieee80211_recalc_idle(struct ieee80211_local *local)
 
 static int ieee80211_change_mtu(struct net_device *dev, int new_mtu)
 {
-	int meshhdrlen;
-	struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
-
-	meshhdrlen = (sdata->vif.type == NL80211_IFTYPE_MESH_POINT) ? 5 : 0;
+	/* 802.11-2012: 8.2.3: The maximum frame body size is determined by
+	1. The maximum MSDU size (2304 octets),
+	2. plus the length of the Mesh Control field (6, 12, or 18 octets)
+		if present,
+	3. the maximum unencrypted MMPDU size excluding the MAC header and
+		FCS (2304 octets) or
+	4. the maximum A- MSDU size (3839 or 7935 octets),
+		plus any overhead from security encapsulation.
+	Note1: IEEE80211_MAX_DATA_LEN doesnt include any headers (2304),
+		so it can be used directly+ Mesh HDR Len
+	Note2: In Other places (skb_alloc) its handled properly.
+
+	ToDO: Make the MAX_DATA_LEN driver configurable through its
+	AMSDU capabilities.
+	 */
 
-	/* FIX: what would be proper limits for MTU?
-	 * This interface uses 802.3 frames. */
 	if (new_mtu < 256 ||
-	    new_mtu > IEEE80211_MAX_DATA_LEN - 24 - 6 - meshhdrlen) {
+	    new_mtu > IEEE80211_MAX_DATA_LEN) {
 		return -EINVAL;
 	}
 





       reply	other threads:[~2012-12-21 11:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201212211141.qBLBfZdq015078@chaitanya-desktop>
2012-12-21 11:45 ` Chaitanya [this message]
2012-12-21 14:11   ` [PATCH] mac80211: Fix the MAX MTU calculation Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D44BCC.30304@posedge.com \
    --to=chaitanyatk@posedge.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.