All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain
Date: Fri, 21 Dec 2012 13:42:55 +0100	[thread overview]
Message-ID: <50D4594F.7010402@mind.be> (raw)
In-Reply-To: <1356086190-906-2-git-send-email-fabio.porcedda@gmail.com>

On 21/12/12 11:36, Fabio Porcedda wrote:
> - Use a more descriptive name, the same of the "toolchain" directory.
> - Add missing dependencies to be able to successfully use the target
>    right after the configuration.
> - Move to a better position.
> - Documentation it in the help target.
>
> Signed-off-by: Fabio Porcedda<fabio.porcedda@gmail.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
  (not tested but it's trivial enough)

  Some additional suggestions (for additional patches):

- Document it in the manual.

- Add toolchain as a dependency to $(1)-configure for target-packages;
this makes it possible to remove it from the dependencies of 'world' and 
brings us a step closer to top-level parallel build.


  Regards,
  Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2012-12-21 12:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-21 10:36 [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target Fabio Porcedda
2012-12-21 10:36 ` [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain Fabio Porcedda
2012-12-21 12:00   ` Markos Chandras
2012-12-21 12:42   ` Arnout Vandecappelle [this message]
2012-12-21 14:15     ` Fabio Porcedda
2012-12-22 12:45   ` Samuel Martin
2012-12-22 13:45     ` Fabio Porcedda
2012-12-21 10:36 ` [Buildroot] [PATCH v2 2/2] Makefile: use toolchain target in the world target Fabio Porcedda
2012-12-21 11:57   ` Markos Chandras
2012-12-21 12:43   ` Arnout Vandecappelle
2013-01-07 12:29 ` [Buildroot] [PATCH v2 0/2] Makefile: add toolchain target Fabio Porcedda
2013-01-13 14:14   ` Samuel Martin
2013-01-13 21:28     ` Fabio Porcedda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D4594F.7010402@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.