All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan de Konink <stefan-01bSGNrlLMOzQB+pC5nmwQ@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: G4 Snowball DPMS 1 fix
Date: Sat, 22 Dec 2012 18:25:21 +0100	[thread overview]
Message-ID: <50D5ED01.2030206@konink.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

Hi,

Since I am a proud owner of a G4 Snowball, and the screen did some
strange things in DPMS 1 (blanking), I thought it was a good idea to fix
it. With some help from IRC I made the attached patch.

Stefan

[-- Attachment #2: dpms-g4-snowball.diff --]
[-- Type: text/x-patch, Size: 1168 bytes --]

commit 4e2b7e05ceb5afb2f1a0b9e5bfd405bbef11a723
Author: Stefan de Konink <stefan-01bSGNrlLMOzQB+pC5nmwQ@public.gmane.org>
Date:   Sat Dec 22 18:04:37 2012 +0100

    drm/nouveau: Fix DPMS 1 on G4 Snowball, from snow white to coal black.
    
    This fixes bug <https://bugs.freedesktop.org/show_bug.cgi?id=40275>
    
    Signed-off-by: Stefan de Konink <stefan-01bSGNrlLMOzQB+pC5nmwQ@public.gmane.org>

diff --git a/drivers/gpu/drm/nouveau/nv04_dfp.c b/drivers/gpu/drm/nouveau/nv04_dfp.c
index 184cdf8..eb76b69 100644
--- a/drivers/gpu/drm/nouveau/nv04_dfp.c
+++ b/drivers/gpu/drm/nouveau/nv04_dfp.c
@@ -490,8 +490,8 @@ static void nv04_dfp_update_backlight(struct drm_encoder *encoder, int mode)
 	/* BIOS scripts usually take care of the backlight, thanks
 	 * Apple for your consistency.
 	 */
-	if (dev->pci_device == 0x0179 || dev->pci_device == 0x0189 ||
-	    dev->pci_device == 0x0329) {
+	if (dev->pci_device == 0x0174 || dev->pci_device == 0x0179 ||
+	    dev->pci_device == 0x0189 || dev->pci_device == 0x0329) {
 		if (mode == DRM_MODE_DPMS_ON) {
 			nv_mask(device, NV_PBUS_DEBUG_DUALHEAD_CTL, 0, 1 << 31);
 			nv_mask(device, NV_PCRTC_GPIO_EXT, 3, 1);

[-- Attachment #3: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

             reply	other threads:[~2012-12-22 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-22 17:25 Stefan de Konink [this message]
     [not found] ` <50D5ED01.2030206-01bSGNrlLMOzQB+pC5nmwQ@public.gmane.org>
2012-12-22 17:46   ` G4 Snowball DPMS 1 fix Marcin Slusarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D5ED01.2030206@konink.de \
    --to=stefan-01bsgnrllmozqb+pc5nmwq@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.