From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: Eric Dumazet <erdnetdev@gmail.com>,
"'netdev@vger.kernel.org'" <netdev@vger.kernel.org>
Cc: davem@davemloft.net, YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH] ipv6 mcast: Fix incorrect use of pskb_may_pull().
Date: Wed, 26 Dec 2012 12:11:27 +0900 [thread overview]
Message-ID: <50DA6ADF.5020003@linux-ipv6.org> (raw)
In-Reply-To: <1356456420.20133.15020.camel@edumazet-glaptop>
Eric Dumazet wrote:
> On Tue, 2012-12-25 at 23:41 +0900, YOSHIFUJI Hideaki wrote:
>
>> + if (!pskb_may_pull(skb, skb->len))
>> + return -EINVAL;
>> +
>
> skb_linearize(skb) might be more explicit then.
Oh, I've found errors, so I'll respin.
--yoshfuji
prev parent reply other threads:[~2012-12-26 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-25 14:41 [PATCH] ipv6 mcast: Fix incorrect use of pskb_may_pull() YOSHIFUJI Hideaki
2012-12-25 17:27 ` Eric Dumazet
2012-12-26 3:11 ` YOSHIFUJI Hideaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DA6ADF.5020003@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@davemloft.net \
--cc=erdnetdev@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.