From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Subject: Re: [PATCH v5 06/14] memory-hotplug: implement register_page_bootmem_info_section of sparse-vmemmap Date: Wed, 26 Dec 2012 11:21:02 +0800 Message-ID: <50DA6D1E.1010209@cn.fujitsu.com> References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-7-git-send-email-tangchen@cn.fujitsu.com> <50D95F51.9090007@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <50D95F51.9090007@huawei.com> Sender: owner-linux-mm@kvack.org To: Jianguo Wu Cc: akpm@linux-foundation.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On 12/25/2012 04:09 PM, Jianguo Wu wrote: >> + >> + if (!cpu=5Fhas=5Fpse) { >> + next =3D (addr + PAGE=5FSIZE)& PAGE=5FMASK; >> + pmd =3D pmd=5Foffset(pud, addr); >> + if (pmd=5Fnone(*pmd)) >> + continue; >> + get=5Fpage=5Fbootmem(section=5Fnr, pmd=5Fpage(*pmd), >> + MIX=5FSECTION=5FINFO); >> + >> + pte =3D pte=5Foffset=5Fkernel(pmd, addr); >> + if (pte=5Fnone(*pte)) >> + continue; >> + get=5Fpage=5Fbootmem(section=5Fnr, pte=5Fpage(*pte), >> + SECTION=5FINFO); >> + } else { >> + next =3D pmd=5Faddr=5Fend(addr, end); >> + >> + pmd =3D pmd=5Foffset(pud, addr); >> + if (pmd=5Fnone(*pmd)) >> + continue; >> + get=5Fpage=5Fbootmem(section=5Fnr, pmd=5Fpage(*pmd), >> + SECTION=5FINFO); > > Hi Tang=EF=BC=8C > In this case, pmd maps 512 pages, but you only get=5Fpage=5Fbootmem() on= the first page. > I think the whole 512 pages should be get=5Fpage=5Fbootmem(), what do you= think? > Hi Wu, Yes, thanks. I will fix it. :) Thanks. :) = -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Date: Wed, 26 Dec 2012 03:21:02 +0000 Subject: Re: [PATCH v5 06/14] memory-hotplug: implement register_page_bootmem_info_section of sparse-vmemmap Message-Id: <50DA6D1E.1010209@cn.fujitsu.com> List-Id: References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-7-git-send-email-tangchen@cn.fujitsu.com> <50D95F51.9090007@huawei.com> In-Reply-To: <50D95F51.9090007@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Jianguo Wu Cc: akpm@linux-foundation.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org On 12/25/2012 04:09 PM, Jianguo Wu wrote: >> + >> + if (!cpu_has_pse) { >> + next =3D (addr + PAGE_SIZE)& PAGE_MASK; >> + pmd =3D pmd_offset(pud, addr); >> + if (pmd_none(*pmd)) >> + continue; >> + get_page_bootmem(section_nr, pmd_page(*pmd), >> + MIX_SECTION_INFO); >> + >> + pte =3D pte_offset_kernel(pmd, addr); >> + if (pte_none(*pte)) >> + continue; >> + get_page_bootmem(section_nr, pte_page(*pte), >> + SECTION_INFO); >> + } else { >> + next =3D pmd_addr_end(addr, end); >> + >> + pmd =3D pmd_offset(pud, addr); >> + if (pmd_none(*pmd)) >> + continue; >> + get_page_bootmem(section_nr, pmd_page(*pmd), >> + SECTION_INFO); > > Hi Tang=EF=BC=8C > In this case, pmd maps 512 pages, but you only get_page_bootmem() on the= first page. > I think the whole 512 pages should be get_page_bootmem(), what do you thi= nk? > Hi Wu, Yes, thanks. I will fix it. :) Thanks. :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from song.cn.fujitsu.com (unknown [222.73.24.84]) by ozlabs.org (Postfix) with ESMTP id 036212C047F for ; Wed, 26 Dec 2012 14:22:00 +1100 (EST) Message-ID: <50DA6D1E.1010209@cn.fujitsu.com> Date: Wed, 26 Dec 2012 11:21:02 +0800 From: Tang Chen MIME-Version: 1.0 To: Jianguo Wu Subject: Re: [PATCH v5 06/14] memory-hotplug: implement register_page_bootmem_info_section of sparse-vmemmap References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-7-git-send-email-tangchen@cn.fujitsu.com> <50D95F51.9090007@huawei.com> In-Reply-To: <50D95F51.9090007@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, paulus@samba.org, hpa@zytor.com, sparclinux@vger.kernel.org, cl@linux.com, linux-s390@vger.kernel.org, x86@kernel.org, linux-acpi@vger.kernel.org, isimatu.yasuaki@jp.fujitsu.com, linfeng@cn.fujitsu.com, mgorman@suse.de, kosaki.motohiro@jp.fujitsu.com, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, wency@cn.fujitsu.com, cmetcalf@tilera.com, yinghai@kernel.org, laijs@cn.fujitsu.com, linux-kernel@vger.kernel.org, minchan.kim@gmail.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/25/2012 04:09 PM, Jianguo Wu wrote: >> + >> + if (!cpu=5Fhas=5Fpse) { >> + next =3D (addr + PAGE=5FSIZE)& PAGE=5FMASK; >> + pmd =3D pmd=5Foffset(pud, addr); >> + if (pmd=5Fnone(*pmd)) >> + continue; >> + get=5Fpage=5Fbootmem(section=5Fnr, pmd=5Fpage(*pmd), >> + MIX=5FSECTION=5FINFO); >> + >> + pte =3D pte=5Foffset=5Fkernel(pmd, addr); >> + if (pte=5Fnone(*pte)) >> + continue; >> + get=5Fpage=5Fbootmem(section=5Fnr, pte=5Fpage(*pte), >> + SECTION=5FINFO); >> + } else { >> + next =3D pmd=5Faddr=5Fend(addr, end); >> + >> + pmd =3D pmd=5Foffset(pud, addr); >> + if (pmd=5Fnone(*pmd)) >> + continue; >> + get=5Fpage=5Fbootmem(section=5Fnr, pmd=5Fpage(*pmd), >> + SECTION=5FINFO); > > Hi Tang=EF=BC=8C > In this case, pmd maps 512 pages, but you only get=5Fpage=5Fbootmem() on= the first page. > I think the whole 512 pages should be get=5Fpage=5Fbootmem(), what do you= think? > Hi Wu, Yes, thanks. I will fix it. :) Thanks. :) = From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753573Ab2LZDWF (ORCPT ); Tue, 25 Dec 2012 22:22:05 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:20988 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753049Ab2LZDWB convert rfc822-to-8bit (ORCPT ); Tue, 25 Dec 2012 22:22:01 -0500 X-IronPort-AV: E=Sophos;i="4.84,355,1355068800"; d="scan'208";a="6474517" Message-ID: <50DA6D1E.1010209@cn.fujitsu.com> Date: Wed, 26 Dec 2012 11:21:02 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jianguo Wu CC: akpm@linux-foundation.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org Subject: Re: [PATCH v5 06/14] memory-hotplug: implement register_page_bootmem_info_section of sparse-vmemmap References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-7-git-send-email-tangchen@cn.fujitsu.com> <50D95F51.9090007@huawei.com> In-Reply-To: <50D95F51.9090007@huawei.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/12/26 11:21:47, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/12/26 11:21:48 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/25/2012 04:09 PM, Jianguo Wu wrote: >> + >> + if (!cpu_has_pse) { >> + next = (addr + PAGE_SIZE)& PAGE_MASK; >> + pmd = pmd_offset(pud, addr); >> + if (pmd_none(*pmd)) >> + continue; >> + get_page_bootmem(section_nr, pmd_page(*pmd), >> + MIX_SECTION_INFO); >> + >> + pte = pte_offset_kernel(pmd, addr); >> + if (pte_none(*pte)) >> + continue; >> + get_page_bootmem(section_nr, pte_page(*pte), >> + SECTION_INFO); >> + } else { >> + next = pmd_addr_end(addr, end); >> + >> + pmd = pmd_offset(pud, addr); >> + if (pmd_none(*pmd)) >> + continue; >> + get_page_bootmem(section_nr, pmd_page(*pmd), >> + SECTION_INFO); > > Hi Tangļ¼Œ > In this case, pmd maps 512 pages, but you only get_page_bootmem() on the first page. > I think the whole 512 pages should be get_page_bootmem(), what do you think? > Hi Wu, Yes, thanks. I will fix it. :) Thanks. :)