Re: [PATCH] fs/ext3: use kzalloc instead of kmalloc

[Chen Gang <gang.chen@asianux.com>]

  I prefer:
    define a macro in .h file and give comments with relative information.
    for function ext3_acl_size, use the macro instead of hard code number "4"
     (then not need to comment for the function ext3_acl_size)

gchen.

于 2012年12月26日 13:08, Chen Gang 写道:
>> Ah, I see.  What's there is OK, but it's not at all obvious that it's
>> > OK.  A valid acl must have a very specific order of tags, as enforced
>> > by posix_acl_valid() in fs/posix_acl.c:
>> > 
>> > ACL_USER_OBJ ACL_USER*[1] ACL_GROUP_OBJ ACL_GROUP*[1] ACL_MASK[2] ACL_OTHER 
>> > 
>> > [1] Where * is the regexp sense of "0 or more times"
>> > [2] Only if there is at least one ACL_USER or ACL_GROUP tag; otherwise
>> > 	skip ACL_MASK.
>> > 
>> > Hence, a valid acl can have at most 4 short acl entry types
>> > (ACL_USER_OBJ, ACL_GROUP, ACL_MASK, and ACL_OTHER), and if there is
>> > less than 4 acl entries, they must all be short acl types.
>> > 
>> > All I can say is, this is a horrible way of coding things, and I wish
>> > this was documented explicitly somewhere either in fs/posix_acl.c or
>> > in include/linux/posix_acl.h.  Yuck, yuck, yuck....
>> > 
>> > 						- Ted
>   learned.
> 
>   :-)
> 
>   also better to give a comment above the function ext3_acl_size.
> 
>   thanks.


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html