All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/9] mx28evk: Add support to dynamically choose between ftd use or not
Date: Wed, 26 Dec 2012 12:15:57 +0100	[thread overview]
Message-ID: <50DADC6D.3080201@denx.de> (raw)
In-Reply-To: <1356109151-6623-7-git-send-email-otavio@ossystems.com.br>

On 21/12/2012 17:59, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---

Hi Otavio,

>  include/configs/mx28evk.h |   15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 3cc0726..5c1c052 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -290,6 +290,8 @@
>  	"uimage=uImage\0" \
>  	"console_fsl=ttyAM0\0" \
>  	"console_mainline=ttyAMA0\0" \
> +	"ftd_file=imx28-evk.dtb\0" \
> +	"ftd_addr=0x41000000\0" \
>  	"mmcdev=0\0" \
>  	"mmcpart=2\0" \
>  	"mmcroot=/dev/mmcblk0p3 rw rootwait\0" \
> @@ -301,13 +303,22 @@
>  	"loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
>  	"mmcboot=echo Booting from mmc ...; " \
>  		"run mmcargs; "	\
> -		"bootm\0" \
> +		"if fatload mmc ${mmcdev}:${mmcpart} ${ftd_addr} ${ftd_file}; then " \
> +			"bootm ${loadaddr} - ${ftd_addr}; " \
> +		"else " \
> +			"bootm; " \
> +		"fi;\0" \
>  	"netargs=setenv bootargs console=${console_mainline},${baudrate} " \
>  		"root=/dev/nfs " \
>  		"ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
>  	"netboot=echo Booting from net ...; " \
>  		"run netargs; "	\
> -		"dhcp ${uimage}; bootm\0"
> +		"dhcp ${uimage}; " \
> +		"if dhcp ${ftd_addr} ${ftd_file}; then " \
> +			"bootm ${loadaddr} - ${ftd_addr}; " \
> +		"else " \
> +			"bootm; " \
> +		"fi;\0"
>  
>  #define CONFIG_BOOTCOMMAND \
>  	"mmc dev ${mmcdev}; if mmc rescan; then " \
> 

Please fix the following warning reported by checkpatch:

WARNING: line over 80 characters
#39: FILE: include/configs/mx28evk.h:306:
+		"if fatload mmc ${mmcdev}:${mmcpart} ${ftd_addr} ${ftd_file}; then " \

total: 0 errors, 1 warnings, 32 lines checked

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2012-12-26 11:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-21 16:59 [U-Boot] [PATCH 0/9] Improve default environment for easy use Otavio Salvador
2012-12-21 16:59 ` [U-Boot] [PATCH 1/9] mx28evk: We shouldn't hardcode a rootfs filesystem type Otavio Salvador
2012-12-26 11:02   ` Stefano Babic
2012-12-26 18:17     ` Otavio Salvador
2012-12-27  9:33       ` Stefano Babic
2012-12-27 10:29         ` Wolfgang Denk
2012-12-27 20:37           ` Otavio Salvador
2012-12-21 16:59 ` [U-Boot] [PATCH 2/9] mx53loco: " Otavio Salvador
2012-12-26 11:07   ` Stefano Babic
2012-12-21 16:59 ` [U-Boot] [PATCH 3/9] mx53loco: Change default loadaddr to 0x72000000 Otavio Salvador
2012-12-26 11:10   ` Stefano Babic
2012-12-21 16:59 ` [U-Boot] [PATCH 4/9] mx6qsabrelite: Change default loadaddr to 0x12000000 Otavio Salvador
2012-12-26 11:12   ` Stefano Babic
2012-12-21 16:59 ` [U-Boot] [PATCH 5/9] mx6qsabre_common: " Otavio Salvador
2012-12-26 11:14   ` Stefano Babic
2012-12-21 16:59 ` [U-Boot] [PATCH 6/9] mx28evk: Add support to dynamically choose between ftd use or not Otavio Salvador
2012-12-26 11:15   ` Stefano Babic [this message]
2012-12-26 18:19     ` Otavio Salvador
2012-12-21 16:59 ` [U-Boot] [PATCH 7/9] mx53loco: " Otavio Salvador
2012-12-26 11:31   ` Stefano Babic
2012-12-26 12:14     ` Fabio Estevam
2012-12-26 18:23       ` Otavio Salvador
2012-12-27  9:44         ` Stefano Babic
2012-12-27 21:22           ` Otavio Salvador
2012-12-28  8:52             ` Stefano Babic
2012-12-28 17:47               ` Otavio Salvador
2012-12-21 16:59 ` [U-Boot] [PATCH 8/9] mx6qsabrelite: " Otavio Salvador
2012-12-21 16:59 ` [U-Boot] [PATCH 9/9] mx6qsabre{auto, sd}: " Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50DADC6D.3080201@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.