Arjan,
   Can you take a look at this patch set. It looks good to me, but I 
wanted to make sure I am not missing something.  There is duplication 
there, but not all.

I have built and run some tests. Seems OK at a glance.
-Chris


-------- Original Message --------
Subject: 	RE: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*
Date: 	Mon, 24 Dec 2012 20:17:54 +0000
From: 	Ferron, Chris E <chris.e.ferron(a)intel.com>
To: 	Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>, Chris Ferron 
<chris.e.ferron(a)linux.intel.com>
CC: 	powertop(a)lists.01.org <powertop(a)lists.01.org>



Thanks, I will attend to outstanding patches on Wednesday (GMT+8) when I return to the office.
-Chris

-----Original Message-----
From: powertop-bounces(a)lists.01.org [mailto:powertop-bounces(a)lists.01.org] On Behalf Of Sergey Senozhatsky
Sent: Monday, December 24, 2012 8:25 AM
To: Chris Ferron
Cc: powertop(a)lists.01.org
Subject: Re: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*

On (12/24/12 03:08), Ivan Shapovalov wrote:
> This is a resend (unchanged but rebased) of the patch series about
> refactoring code in cpu/* by deduplication. From this series, only the
> last bugfix patch has been applied so far due to a code freeze.
>
> Ivan Shapovalov (10):
>       Fix includes: do not include intel_cpus.h inside cpu.h
>       Deduplication: move is_turbo() function to lib
>       Deduplication: move all instances of account_freq() to abstract_cpu::account_freq()
>       Deduplication: remove nhm_cpu::account_freq() almost identical to abstract_cpu::account_freq()
>       Deduplication: remove nhm_{cpu,core,package}::change_effective_frequency() identical to cpu_{linux,core,package}::change_effective_frequency()
>       Deduplication: merge cpu_{core,linux,package}::change_effective_frequency() into abstract_cpu::change_effective_frequency()
>       Deduplication: remove {cpu,nhm}_core::calculate_freq() identical to abstract_cpu::calculate_freq()
>       Deduplication: remove nhm_package::calculate_freq() identical to cpu_package::calculate_freq()
>       Deduplication: properly merge cpu_package::calculate_freq() into abstract_cpu::calculate_freq()
>       Deduplication: merge go_idle()/go_unidle()/change_freq()
> overrides into abstract_cpu() class
>

Hello Chris,
patch series looks good to me. thanks to Ivan.

please note V3 of 02 and 03 patches.


	-ss
_______________________________________________
PowerTop mailing list
PowerTop(a)lists.01.org
https://lists.01.org/mailman/listinfo/powertop