From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Subject: Re: [PATCH v5 04/14] memory-hotplug: remove /sys/firmware/memmap/X sysfs Date: Thu, 27 Dec 2012 11:09:35 +0800 Message-ID: <50DBBBEF.70701@cn.fujitsu.com> References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-5-git-send-email-tangchen@cn.fujitsu.com> <50DA6F5A.2070601@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50DA6F5A.2070601@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: Kamezawa Hiroyuki Cc: akpm@linux-foundation.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On 12/26/2012 11:30 AM, Kamezawa Hiroyuki wrote: >> @@ -41,6 +42,7 @@ struct firmware_map_entry { >> const char *type; /* type of the memory range */ >> struct list_head list; /* entry for the linked list */ >> struct kobject kobj; /* kobject for each entry */ >> + unsigned int bootmem:1; /* allocated from bootmem */ >> }; > > Can't we detect from which the object is allocated from, slab or bootmem ? > > Hm, for example, > > PageReserved(virt_to_page(address_of_obj)) ? > PageSlab(virt_to_page(address_of_obj)) ? > Hi Kamezawa-san, I think we can detect it without a new member. I think bootmem:1 member is just for convenience. I think I can remove it. :) Thanks. :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Date: Thu, 27 Dec 2012 03:09:35 +0000 Subject: Re: [PATCH v5 04/14] memory-hotplug: remove /sys/firmware/memmap/X sysfs Message-Id: <50DBBBEF.70701@cn.fujitsu.com> List-Id: References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-5-git-send-email-tangchen@cn.fujitsu.com> <50DA6F5A.2070601@jp.fujitsu.com> In-Reply-To: <50DA6F5A.2070601@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kamezawa Hiroyuki Cc: akpm@linux-foundation.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org On 12/26/2012 11:30 AM, Kamezawa Hiroyuki wrote: >> @@ -41,6 +42,7 @@ struct firmware_map_entry { >> const char *type; /* type of the memory range */ >> struct list_head list; /* entry for the linked list */ >> struct kobject kobj; /* kobject for each entry */ >> + unsigned int bootmem:1; /* allocated from bootmem */ >> }; > > Can't we detect from which the object is allocated from, slab or bootmem ? > > Hm, for example, > > PageReserved(virt_to_page(address_of_obj)) ? > PageSlab(virt_to_page(address_of_obj)) ? > Hi Kamezawa-san, I think we can detect it without a new member. I think bootmem:1 member is just for convenience. I think I can remove it. :) Thanks. :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from song.cn.fujitsu.com (unknown [222.73.24.84]) by ozlabs.org (Postfix) with ESMTP id 4C1D02C023B for ; Thu, 27 Dec 2012 14:10:32 +1100 (EST) Message-ID: <50DBBBEF.70701@cn.fujitsu.com> Date: Thu, 27 Dec 2012 11:09:35 +0800 From: Tang Chen MIME-Version: 1.0 To: Kamezawa Hiroyuki Subject: Re: [PATCH v5 04/14] memory-hotplug: remove /sys/firmware/memmap/X sysfs References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-5-git-send-email-tangchen@cn.fujitsu.com> <50DA6F5A.2070601@jp.fujitsu.com> In-Reply-To: <50DA6F5A.2070601@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-2022-JP Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, paulus@samba.org, hpa@zytor.com, sparclinux@vger.kernel.org, cl@linux.com, linux-s390@vger.kernel.org, x86@kernel.org, linux-acpi@vger.kernel.org, isimatu.yasuaki@jp.fujitsu.com, linfeng@cn.fujitsu.com, mgorman@suse.de, kosaki.motohiro@jp.fujitsu.com, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, wency@cn.fujitsu.com, cmetcalf@tilera.com, wujianguo@huawei.com, yinghai@kernel.org, laijs@cn.fujitsu.com, linux-kernel@vger.kernel.org, minchan.kim@gmail.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/26/2012 11:30 AM, Kamezawa Hiroyuki wrote: >> @@ -41,6 +42,7 @@ struct firmware_map_entry { >> const char *type; /* type of the memory range */ >> struct list_head list; /* entry for the linked list */ >> struct kobject kobj; /* kobject for each entry */ >> + unsigned int bootmem:1; /* allocated from bootmem */ >> }; > > Can't we detect from which the object is allocated from, slab or bootmem ? > > Hm, for example, > > PageReserved(virt_to_page(address_of_obj)) ? > PageSlab(virt_to_page(address_of_obj)) ? > Hi Kamezawa-san, I think we can detect it without a new member. I think bootmem:1 member is just for convenience. I think I can remove it. :) Thanks. :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752446Ab2L0DKh (ORCPT ); Wed, 26 Dec 2012 22:10:37 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:18341 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751177Ab2L0DKe (ORCPT ); Wed, 26 Dec 2012 22:10:34 -0500 X-IronPort-AV: E=Sophos;i="4.84,360,1355068800"; d="scan'208";a="6482683" Message-ID: <50DBBBEF.70701@cn.fujitsu.com> Date: Thu, 27 Dec 2012 11:09:35 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Kamezawa Hiroyuki CC: akpm@linux-foundation.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org Subject: Re: [PATCH v5 04/14] memory-hotplug: remove /sys/firmware/memmap/X sysfs References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-5-git-send-email-tangchen@cn.fujitsu.com> <50DA6F5A.2070601@jp.fujitsu.com> In-Reply-To: <50DA6F5A.2070601@jp.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/12/27 11:10:18, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/12/27 11:10:18, Serialize complete at 2012/12/27 11:10:18 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-2022-JP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/26/2012 11:30 AM, Kamezawa Hiroyuki wrote: >> @@ -41,6 +42,7 @@ struct firmware_map_entry { >> const char *type; /* type of the memory range */ >> struct list_head list; /* entry for the linked list */ >> struct kobject kobj; /* kobject for each entry */ >> + unsigned int bootmem:1; /* allocated from bootmem */ >> }; > > Can't we detect from which the object is allocated from, slab or bootmem ? > > Hm, for example, > > PageReserved(virt_to_page(address_of_obj)) ? > PageSlab(virt_to_page(address_of_obj)) ? > Hi Kamezawa-san, I think we can detect it without a new member. I think bootmem:1 member is just for convenience. I think I can remove it. :) Thanks. :)