From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Subject: Re: [PATCH v5 02/14] memory-hotplug: check whether all memory blocks are offlined or not when removing memory Date: Thu, 27 Dec 2012 11:10:56 +0800 Message-ID: <50DBBC40.6040700@cn.fujitsu.com> References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-3-git-send-email-tangchen@cn.fujitsu.com> <50DA6AB3.2030608@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50DA6AB3.2030608@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: Kamezawa Hiroyuki Cc: akpm@linux-foundation.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On 12/26/2012 11:10 AM, Kamezawa Hiroyuki wrote: > (2012/12/24 21:09), Tang Chen wrote: >> From: Yasuaki Ishimatsu >> >> We remove the memory like this: >> 1. lock memory hotplug >> 2. offline a memory block >> 3. unlock memory hotplug >> 4. repeat 1-3 to offline all memory blocks >> 5. lock memory hotplug >> 6. remove memory(TODO) >> 7. unlock memory hotplug >> >> All memory blocks must be offlined before removing memory. But we don't hold >> the lock in the whole operation. So we should check whether all memory blocks >> are offlined before step6. Otherwise, kernel maybe panicked. >> >> Signed-off-by: Wen Congyang >> Signed-off-by: Yasuaki Ishimatsu > > Acked-by: KAMEZAWA Hiroyuki > > a nitpick below. > >> + >> + for (pfn = start_pfn; pfn< end_pfn; pfn += PAGES_PER_SECTION) { > > I prefer adding mem = NULL at the start of this for(). Hi Kamezawa-san, Added, thanks. :) > >> + section_nr = pfn_to_section_nr(pfn); >> + if (!present_section_nr(section_nr)) >> + continue; >> + >> + section = __nr_to_section(section_nr); >> + /* same memblock? */ >> + if (mem) >> + if ((section_nr>= mem->start_section_nr)&& >> + (section_nr<= mem->end_section_nr)) >> + continue; >> + > > Thanks, > -Kame > > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Date: Thu, 27 Dec 2012 03:10:56 +0000 Subject: Re: [PATCH v5 02/14] memory-hotplug: check whether all memory blocks are offlined or not when removi Message-Id: <50DBBC40.6040700@cn.fujitsu.com> List-Id: References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-3-git-send-email-tangchen@cn.fujitsu.com> <50DA6AB3.2030608@jp.fujitsu.com> In-Reply-To: <50DA6AB3.2030608@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kamezawa Hiroyuki Cc: akpm@linux-foundation.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org On 12/26/2012 11:10 AM, Kamezawa Hiroyuki wrote: > (2012/12/24 21:09), Tang Chen wrote: >> From: Yasuaki Ishimatsu >> >> We remove the memory like this: >> 1. lock memory hotplug >> 2. offline a memory block >> 3. unlock memory hotplug >> 4. repeat 1-3 to offline all memory blocks >> 5. lock memory hotplug >> 6. remove memory(TODO) >> 7. unlock memory hotplug >> >> All memory blocks must be offlined before removing memory. But we don't hold >> the lock in the whole operation. So we should check whether all memory blocks >> are offlined before step6. Otherwise, kernel maybe panicked. >> >> Signed-off-by: Wen Congyang >> Signed-off-by: Yasuaki Ishimatsu > > Acked-by: KAMEZAWA Hiroyuki > > a nitpick below. > >> + >> + for (pfn = start_pfn; pfn< end_pfn; pfn += PAGES_PER_SECTION) { > > I prefer adding mem = NULL at the start of this for(). Hi Kamezawa-san, Added, thanks. :) > >> + section_nr = pfn_to_section_nr(pfn); >> + if (!present_section_nr(section_nr)) >> + continue; >> + >> + section = __nr_to_section(section_nr); >> + /* same memblock? */ >> + if (mem) >> + if ((section_nr>= mem->start_section_nr)&& >> + (section_nr<= mem->end_section_nr)) >> + continue; >> + > > Thanks, > -Kame > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from song.cn.fujitsu.com (unknown [222.73.24.84]) by ozlabs.org (Postfix) with ESMTP id 534CB2C00DB for ; Thu, 27 Dec 2012 14:11:54 +1100 (EST) Message-ID: <50DBBC40.6040700@cn.fujitsu.com> Date: Thu, 27 Dec 2012 11:10:56 +0800 From: Tang Chen MIME-Version: 1.0 To: Kamezawa Hiroyuki Subject: Re: [PATCH v5 02/14] memory-hotplug: check whether all memory blocks are offlined or not when removing memory References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-3-git-send-email-tangchen@cn.fujitsu.com> <50DA6AB3.2030608@jp.fujitsu.com> In-Reply-To: <50DA6AB3.2030608@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-2022-JP Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, paulus@samba.org, hpa@zytor.com, sparclinux@vger.kernel.org, cl@linux.com, linux-s390@vger.kernel.org, x86@kernel.org, linux-acpi@vger.kernel.org, isimatu.yasuaki@jp.fujitsu.com, linfeng@cn.fujitsu.com, mgorman@suse.de, kosaki.motohiro@jp.fujitsu.com, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, wency@cn.fujitsu.com, cmetcalf@tilera.com, wujianguo@huawei.com, yinghai@kernel.org, laijs@cn.fujitsu.com, linux-kernel@vger.kernel.org, minchan.kim@gmail.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/26/2012 11:10 AM, Kamezawa Hiroyuki wrote: > (2012/12/24 21:09), Tang Chen wrote: >> From: Yasuaki Ishimatsu >> >> We remove the memory like this: >> 1. lock memory hotplug >> 2. offline a memory block >> 3. unlock memory hotplug >> 4. repeat 1-3 to offline all memory blocks >> 5. lock memory hotplug >> 6. remove memory(TODO) >> 7. unlock memory hotplug >> >> All memory blocks must be offlined before removing memory. But we don't hold >> the lock in the whole operation. So we should check whether all memory blocks >> are offlined before step6. Otherwise, kernel maybe panicked. >> >> Signed-off-by: Wen Congyang >> Signed-off-by: Yasuaki Ishimatsu > > Acked-by: KAMEZAWA Hiroyuki > > a nitpick below. > >> + >> + for (pfn = start_pfn; pfn< end_pfn; pfn += PAGES_PER_SECTION) { > > I prefer adding mem = NULL at the start of this for(). Hi Kamezawa-san, Added, thanks. :) > >> + section_nr = pfn_to_section_nr(pfn); >> + if (!present_section_nr(section_nr)) >> + continue; >> + >> + section = __nr_to_section(section_nr); >> + /* same memblock? */ >> + if (mem) >> + if ((section_nr>= mem->start_section_nr)&& >> + (section_nr<= mem->end_section_nr)) >> + continue; >> + > > Thanks, > -Kame > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164Ab2L0DL5 (ORCPT ); Wed, 26 Dec 2012 22:11:57 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:42562 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751460Ab2L0DLy (ORCPT ); Wed, 26 Dec 2012 22:11:54 -0500 X-IronPort-AV: E=Sophos;i="4.84,360,1355068800"; d="scan'208";a="6482701" Message-ID: <50DBBC40.6040700@cn.fujitsu.com> Date: Thu, 27 Dec 2012 11:10:56 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Kamezawa Hiroyuki CC: akpm@linux-foundation.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org Subject: Re: [PATCH v5 02/14] memory-hotplug: check whether all memory blocks are offlined or not when removing memory References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-3-git-send-email-tangchen@cn.fujitsu.com> <50DA6AB3.2030608@jp.fujitsu.com> In-Reply-To: <50DA6AB3.2030608@jp.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/12/27 11:11:38, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/12/27 11:11:40, Serialize complete at 2012/12/27 11:11:40 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-2022-JP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/26/2012 11:10 AM, Kamezawa Hiroyuki wrote: > (2012/12/24 21:09), Tang Chen wrote: >> From: Yasuaki Ishimatsu >> >> We remove the memory like this: >> 1. lock memory hotplug >> 2. offline a memory block >> 3. unlock memory hotplug >> 4. repeat 1-3 to offline all memory blocks >> 5. lock memory hotplug >> 6. remove memory(TODO) >> 7. unlock memory hotplug >> >> All memory blocks must be offlined before removing memory. But we don't hold >> the lock in the whole operation. So we should check whether all memory blocks >> are offlined before step6. Otherwise, kernel maybe panicked. >> >> Signed-off-by: Wen Congyang >> Signed-off-by: Yasuaki Ishimatsu > > Acked-by: KAMEZAWA Hiroyuki > > a nitpick below. > >> + >> + for (pfn = start_pfn; pfn< end_pfn; pfn += PAGES_PER_SECTION) { > > I prefer adding mem = NULL at the start of this for(). Hi Kamezawa-san, Added, thanks. :) > >> + section_nr = pfn_to_section_nr(pfn); >> + if (!present_section_nr(section_nr)) >> + continue; >> + >> + section = __nr_to_section(section_nr); >> + /* same memblock? */ >> + if (mem) >> + if ((section_nr>= mem->start_section_nr)&& >> + (section_nr<= mem->end_section_nr)) >> + continue; >> + > > Thanks, > -Kame > > >