From: Joshua Kinard <kumba@gentoo.org>
To: Linux MIPS List <linux-mips@linux-mips.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH]: Fix 3.7 mips build if !CONFIG_MODULES
Date: Thu, 27 Dec 2012 04:39:25 -0500 [thread overview]
Message-ID: <50DC174D.6090302@gentoo.org> (raw)
The attached patch fixes a build failure if building a monolithic kernel due
to arch/mips/kernel/Kconfig selecting MODULES_USE_ELF_REL[A] without
checking to see if MODULES is set or not. This leads to 'struct module' not
existing, which triggers a compile failure in arch/mips/kernel/module-rela.c
when the compiler attempts to dereference me->name on lines 36, 48, and 133.
Signed-off-by: Joshua Kinard <kumba@gentoo.org>
---
Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -Naurp a/arch/mips/Kconfig b/arch/mips/Kconfig
--- a/arch/mips/Kconfig 2012-12-22 22:52:28.264461836 -0500
+++ b/arch/mips/Kconfig 2012-12-26 23:00:46.202996691 -0500
@@ -39,8 +39,8 @@ config MIPS
select GENERIC_CLOCKEVENTS
select GENERIC_CMOS_UPDATE
select HAVE_MOD_ARCH_SPECIFIC
- select MODULES_USE_ELF_REL
- select MODULES_USE_ELF_RELA if 64BIT
+ select MODULES_USE_ELF_REL && MODULES
+ select MODULES_USE_ELF_RELA if MODULES && 64BIT
menu "Machine selection"
next reply other threads:[~2012-12-27 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 9:39 Joshua Kinard [this message]
2012-12-27 9:45 ` [PATCH]: Fix 3.7 mips build if !CONFIG_MODULES Geert Uytterhoeven
2012-12-27 19:44 ` Joshua Kinard
2012-12-27 19:46 ` [PATCH v2]: " Joshua Kinard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DC174D.6090302@gentoo.org \
--to=kumba@gentoo.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.