From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 27 Dec 2012 20:46:34 +0100 (CET) Received: from qmta04.westchester.pa.mail.comcast.net ([76.96.62.40]:57070 "EHLO qmta04.westchester.pa.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6822999Ab2L0TqdXzu-L (ORCPT ); Thu, 27 Dec 2012 20:46:33 +0100 Received: from omta14.westchester.pa.mail.comcast.net ([76.96.62.60]) by qmta04.westchester.pa.mail.comcast.net with comcast id ggTz1k0091HzFnQ54jmTaE; Thu, 27 Dec 2012 19:46:27 +0000 Received: from [192.168.1.13] ([76.106.69.86]) by omta14.westchester.pa.mail.comcast.net with comcast id gjmS1k0171rgsis3ajmSqQ; Thu, 27 Dec 2012 19:46:27 +0000 Message-ID: <50DCA5A6.5010409@gentoo.org> Date: Thu, 27 Dec 2012 14:46:46 -0500 From: Joshua Kinard User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: linux-mips@linux-mips.org CC: Ralf Baechle Subject: [PATCH v2]: Fix 3.7 mips build if !CONFIG_MODULES References: <50DC174D.6090302@gentoo.org> In-Reply-To: <50DC174D.6090302@gentoo.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1356637587; bh=G2ulGK3CR9sC5tSbUKBARlWtiizaxK9KaeH5r4+OUQ0=; h=Received:Received:Message-ID:Date:From:MIME-Version:To:Subject: Content-Type; b=XQrMZ9yvce/BPNGKOUIaYNLodCNYUTArGCeSJvGh/S/hn8Dtf+eyO9JcGI9tEVIXj +qstpKohXjasxX3L2tWJKE09nWFbAOyHyVGNHVmgimr/ukRmIZK5VKN8se2uPp1K1+ lEuQqKSuGU24czHE9wywnOUBDtC0pEEAG8IQpn6HcqGsN/Aw/MdT2sZb0BkYUfboyS shdB630F3UeH5s8mI5q2JFsp7VKuNOHHopVjFb6HFTEX0W3tSKRpUhTm6o1cDbdEjN uuWP0bnsbE0K40CC+q721kNtATciWSY3wdUgNZey4ItI5mek3Ad9tgTES4dtbNzToD FgbtcHVzGuIHw== X-archive-position: 35340 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: kumba@gentoo.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: The attached patch fixes a build failure if building a monolithic kernel due to arch/mips/kernel/Kconfig selecting MODULES_USE_ELF_REL[A] without checking to see if MODULES is set or not. This leads to 'struct module' not existing, which triggers a compile failure in arch/mips/kernel/module-rela.c when the compiler attempts to dereference me->name on lines 36, 48, and 133. Signed-off-by: Joshua Kinard --- Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -Naurp a/arch/mips/Kconfig b/arch/mips/Kconfig --- a/arch/mips/Kconfig 2012-12-22 22:52:28.264461836 -0500 +++ b/arch/mips/Kconfig 2012-12-26 23:00:46.202996691 -0500 @@ -39,8 +39,8 @@ config MIPS select GENERIC_CLOCKEVENTS select GENERIC_CMOS_UPDATE select HAVE_MOD_ARCH_SPECIFIC - select MODULES_USE_ELF_REL - select MODULES_USE_ELF_RELA if 64BIT + select MODULES_USE_ELF_REL if MODULES + select MODULES_USE_ELF_RELA if MODULES && 64BIT menu "Machine selection"