From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, realmode: set real_mode permissions early
Date: Thu, 27 Dec 2012 16:01:36 -0800 [thread overview]
Message-ID: <50DCE160.2040707@zytor.com> (raw)
In-Reply-To: <CAE9FiQXpAB_AFtHF_NN7yr2iP2OOLgMir8MNvYUUc15k83_3zg@mail.gmail.com>
On 12/27/2012 03:56 PM, Yinghai Lu wrote:
>>
>> I'm looking at this patch in the -v8 branch: you need to update the
>> comment above that function to say that trampoline code needs to be
>> marked X now earlier.
>
> Not sure if we really need to add such comment in the code.
>
> Peter, what is your idea about this?
>
It would be good to note why the early_initcall is the right phase.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-12-28 0:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 18:22 [PATCH] x86, realmode: set real_mode permissions early Borislav Petkov
2012-12-27 23:56 ` Yinghai Lu
2012-12-28 0:01 ` H. Peter Anvin [this message]
2012-12-28 0:57 ` Yinghai Lu
2012-12-28 1:09 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DCE160.2040707@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.