From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: john@phrozen.org, ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 0/6] MIPS: BCM47XX: nvram read enhancements
Date: Fri, 28 Dec 2012 12:32:49 +0100 [thread overview]
Message-ID: <50DD8361.80805@hauke-m.de> (raw)
In-Reply-To: <CACna6rzAS0zwERF1kA=FXAsO7ROXb9qyEcLyQ7Uc7i=KBOrS+A@mail.gmail.com>
On 12/28/2012 01:00 AM, Rafał Miłecki wrote:
> 2012/12/27 Hauke Mehrtens <hauke@hauke-m.de>:
>> On 12/27/2012 09:49 AM, Rafał Miłecki wrote:
>>> 2012/12/26 Hauke Mehrtens <hauke@hauke-m.de>:
>>>> Clean up the nvram reading code and add support for different nvram
>>>> sizes.
>>>>
>>>> This depends on patch "MIPS: bcm47xx: separate functions finding flash
>>>> window addr" by Rafał Miłeck, Patchwork: https://patchwork.linux-mips.org/patch/4738/
>>>>
>>>> Hauke Mehrtens (6):
>>>> MIPS: BCM47XX: use common error codes in nvram reads
>>>> MIPS: BCM47XX: return error when init of nvram failed
>>>> MIPS: BCM47XX: nvram add nand flash support
>>>> MIPS: BCM47XX: rename early_nvram_init to nvram_init
>>>> MIPS: BCM47XX: handle different nvram sizes
>>>> MIPS: BCM47XX: add bcm47xx prefix in front of nvram function names
>>>
>>> Hm, the only question? Why so late ;) I've spent 3 hours yesterday
>>> debugging nvram on my WNDR4500, it didn't fill SPROM of PCIe cards
>>> correctly. Will test your patches today.
>>
>> I waited till the bit in the flash part in bcma got into the mips tree.
>> Most of the patches in this series were already in my tree and OpenWrt
>> for some time.
>>
>> Does it work now? Your patch was the most important one. In this series
>> only the "handle different nvram sizes" could fix the problem with your
>> device.
>
> I didn't have access to the hardware until now. It seems to be working
> now! I don't get invalid SPROM with rev 0 anymore.
>
> The only message log that bothers me is:
> [ 0.716000] bcma: bus1: invalid sprom read from the PCIe card, try
> to use fallback sprom
> [ 0.812000] can not parse nvram name pci/1/1/mcsbw402gpo(null) with
> value 0x0x88800000 got -22
Nice, an other form of invalid syntax (0x0x88800000) in the nvram, lets
see what the vendors do next. ;-)
This particular issue should not be a problem neither b43 nor brcmsmac
is reading this value and all the other values should be read from nvram
correctly.
Hauke
> I didn't have time to track it yet.
>
next prev parent reply other threads:[~2012-12-28 11:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 20:51 [PATCH 0/6] MIPS: BCM47XX: nvram read enhancements Hauke Mehrtens
2012-12-26 20:51 ` [PATCH 1/6] MIPS: BCM47XX: use common error codes in nvram reads Hauke Mehrtens
2012-12-26 20:51 ` [PATCH 2/6] MIPS: BCM47XX: return error when init of nvram failed Hauke Mehrtens
2012-12-26 20:51 ` [PATCH 3/6] MIPS: BCM47XX: nvram add nand flash support Hauke Mehrtens
2012-12-26 20:51 ` [PATCH 4/6] MIPS: BCM47XX: rename early_nvram_init to nvram_init Hauke Mehrtens
2012-12-26 20:51 ` [PATCH 5/6] MIPS: BCM47XX: handle different nvram sizes Hauke Mehrtens
2012-12-26 20:51 ` [PATCH 6/6] MIPS: BCM47XX: add bcm47xx prefix in front of nvram function names Hauke Mehrtens
2012-12-27 8:49 ` [PATCH 0/6] MIPS: BCM47XX: nvram read enhancements Rafał Miłecki
2012-12-27 12:54 ` Hauke Mehrtens
2012-12-28 0:00 ` Rafał Miłecki
2012-12-28 11:32 ` Hauke Mehrtens [this message]
2012-12-28 0:01 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DD8361.80805@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.