From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/8] sierramodem: Add skeleton cdma netreg driver
Date: Sun, 30 Dec 2012 20:11:21 -0600 [thread overview]
Message-ID: <50E0F449.1080907@gmail.com> (raw)
In-Reply-To: <20121228193458.GH18339@alittletooquiet.net>
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
Hi Forest,
> +static int sierra_cdma_netreg_probe(struct ofono_cdma_netreg *netreg,
> + unsigned int vendor, void *chat)
> +{
> + struct sierra_netreg_data *data;
> +
> + data = g_try_new0(struct sierra_netreg_data, 1);
> + if (data == NULL)
> + return -ENOMEM;
> +
> + ofono_cdma_netreg_set_data(netreg, data);
> +
> + data->chat = g_at_chat_clone(chat);
> +
> + ofono_cdma_netreg_register(netreg);
In general one cannot call register from the probe function. You should
be using an idle callback here
> +
> + return 0;
> +}
Regards,
-Denis
next prev parent reply other threads:[~2012-12-31 2:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 19:31 [PATCH 0/8] Sierra Wireless CDMA modem support Forest Bond
2012-12-28 19:34 ` [PATCH 1/8] sierramodem: Add skeleton for Sierra Wireless modem driver Forest Bond
2012-12-28 19:34 ` [PATCH 2/8] sierramodem: Add skeleton cdma netreg driver Forest Bond
2012-12-31 2:11 ` Denis Kenzior [this message]
2012-12-28 19:35 ` [PATCH 3/8] sierramodem: Add ERI parsing functions Forest Bond
2012-12-31 2:19 ` Denis Kenzior
2012-12-28 19:35 ` [PATCH 4/8] sierramodem: Report network registration status Forest Bond
2012-12-31 2:26 ` Denis Kenzior
2012-12-28 19:35 ` [PATCH 5/8] sierra: Create GPRS context in post_sim function Forest Bond
2012-12-31 2:39 ` Denis Kenzior
2012-12-28 19:36 ` [PATCH 6/8] sierra: Initialize GSM error reporting separately Forest Bond
2012-12-31 2:40 ` Denis Kenzior
2012-12-28 19:36 ` [PATCH 7/8] sierra: Support CDMA modems Forest Bond
2012-12-31 2:34 ` Denis Kenzior
2013-03-04 16:48 ` Forest Bond
2013-03-04 23:03 ` Denis Kenzior
2013-03-05 19:36 ` Forest Bond
2013-03-05 20:52 ` Denis Kenzior
2013-03-05 21:45 ` =?unknown-8bit?q?Bj=C3=B8rn?= Mork
2013-03-05 22:15 ` Forest Bond
2013-03-06 9:43 ` =?unknown-8bit?q?Bj=C3=B8rn?= Mork
2013-03-06 13:36 ` Forest Bond
2012-12-28 19:36 ` [PATCH 8/8] udevng: Support single-interface sierra devices Forest Bond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E0F449.1080907@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.