From mboxrd@z Thu Jan 1 00:00:00 1970 From: gshark Date: Wed, 02 Jan 2013 08:07:37 +0000 Subject: Re: [PATCH] backlight: lm3649_backlight: remove ret = -EIO at error paths of probe Message-Id: <50E3EAC9.9070705@gmail.com> List-Id: References: <1356977911-13521-1-git-send-email-devendra.aaru@gmail.com> In-Reply-To: <1356977911-13521-1-git-send-email-devendra.aaru@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: base64 To: linux-fbdev@vger.kernel.org CgoyMDEzs+IgMDG/+SAwMsDPIDA4OjQ3LCBKaW5nb28gSGFuIL60ILHbOgo+IE9uIFR1ZXNkYXks IEphbnVhcnkgMDEsIDIwMTMgMzoxOSBBTSwgRGV2ZW5kcmEgTmFnYSB3cm90ZQo+PiB0aGUgQVBJ cyBhcmUgcmV0dXJuaW5nIGNvcnJlY3RseSB0aGUgZXJyIGNvZGVzLCBubyBuZWVkIG9mIGFzc2ln bmluZyAtRUlPIHRvIHRoZQo+PiByZXQgYWdhaW4KPj4KPj4gQ2M6IERhbmllbCBKZW9uZyA8ZGFu aWVsLmplb25nQHRpLmNvbT4KPj4gQ2M6IEcuU2hhcmsgSmVvbmcgPGdzaGFyay5qZW9uZ0BnbWFp bC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IERldmVuZHJhIE5hZ2EgPGRldmVuZHJhLmFhcnVAZ21h aWwuY29tPgo+IEl0IGxvb2tzIGdvb2QuCj4gQWNrZWQtYnk6IEppbmdvbyBIYW4gPGpnMS5oYW5A c2Ftc3VuZy5jb20+Cj4KPgo+IEJlc3QgcmVnYXJkcywKPiBKaW5nb28gSGFuCj4KPj4gLS0tCj4+ ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9sbTM2MzlfYmwuYyB8ICAgIDUgKy0tLS0KPj4gIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgNCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2xtMzYzOV9ibC5jIGIvZHJpdmVycy92aWRl by9iYWNrbGlnaHQvbG0zNjM5X2JsLmMKPj4gaW5kZXggN2FiMmQyYS4uMDUzOTY0ZCAxMDA2NDQK Pj4gLS0tIGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbG0zNjM5X2JsLmMKPj4gKysrIGIvZHJp dmVycy92aWRlby9iYWNrbGlnaHQvbG0zNjM5X2JsLmMKPj4gQEAgLTM1MCwxNCArMzUwLDEzIEBA IHN0YXRpYyBpbnQgbG0zNjM5X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsCj4+ICAJ CQkJICAgICAgJmxtMzYzOV9ibGVkX29wcywgJnByb3BzKTsKPj4gIAlpZiAoSVNfRVJSKHBjaGlw LT5ibGVkKSkgewo+PiAgCQlkZXZfZXJyKCZjbGllbnQtPmRldiwgImZhaWwgOiBiYWNrbGlnaHQg cmVnaXN0ZXJcbiIpOwo+PiAtCQlyZXQgPSAtRUlPOwo+PiArCQlyZXQgPSBQVFJfRVJSKHBjaGlw LT5ibGVkKTsKPj4gIAkJZ290byBlcnJfb3V0Owo+PiAgCX0KPj4KPj4gIAlyZXQgPSBkZXZpY2Vf Y3JlYXRlX2ZpbGUoJihwY2hpcC0+YmxlZC0+ZGV2KSwgJmRldl9hdHRyX2JsZWRfbW9kZSk7Cj4+ ICAJaWYgKHJldCA8IDApIHsKPj4gIAkJZGV2X2VycigmY2xpZW50LT5kZXYsICJmYWlsZWQgOiBh ZGQgc3lzZnMgZW50cmllc1xuIik7Cj4+IC0JCXJldCA9IC1FSU87Cj4+ICAJCWdvdG8gZXJyX2Js ZWRfbW9kZTsKPj4gIAl9Cj4+Cj4+IEBAIC0zNjksNyArMzY4LDYgQEAgc3RhdGljIGludCBsbTM2 MzlfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwKPj4gIAkJCQkgICAgJmNsaWVudC0+ ZGV2LCAmcGNoaXAtPmNkZXZfZmxhc2gpOwo+PiAgCWlmIChyZXQgPCAwKSB7Cj4+ICAJCWRldl9l cnIoJmNsaWVudC0+ZGV2LCAiZmFpbCA6IGZsYXNoIHJlZ2lzdGVyXG4iKTsKPj4gLQkJcmV0ID0g LUVJTzsKPj4gIAkJZ290byBlcnJfZmxhc2g7Cj4+ICAJfQo+Pgo+PiBAQCAtMzgxLDcgKzM3OSw2 IEBAIHN0YXRpYyBpbnQgbG0zNjM5X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsCj4+ ICAJCQkJICAgICZjbGllbnQtPmRldiwgJnBjaGlwLT5jZGV2X3RvcmNoKTsKPj4gIAlpZiAocmV0 IDwgMCkgewo+PiAgCQlkZXZfZXJyKCZjbGllbnQtPmRldiwgImZhaWwgOiB0b3JjaCByZWdpc3Rl clxuIik7Cj4+IC0JCXJldCA9IC1FSU87Cj4+ICAJCWdvdG8gZXJyX3RvcmNoOwo+PiAgCX0KPj4K Pj4gLS0KPj4gMS43LjEwLjQKPj4KPj4gLS0KPj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxp c3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LWZiZGV2IiBpbgo+PiB0aGUgYm9k eSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwo+PiBNb3JlIG1ham9y ZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK ClRoYW5rIHlvdS4gVGhpcyBwYXRjaCBsb29rcyBnb29kIGZvciB1cy4KbG0zNjMwIGhhcyBzYW1l IHRoaW5nIGFuZCBJIHdpbGwgZml4IGl0LgoKQWNrZWQtYnk6IERhbmllbCBKZW9uZyA8ZGFuaWVs Lmplb25nQHRpLmNvbT4KCi0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRo ZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1mYmRldiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdl IHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0 cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1s