From: Antti Palosaari <crope@iki.fi>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-media@vger.kernel.org, Malcolm Priestley <tvboxspy@gmail.com>
Subject: Re: [PATCH RFC 07/11] it913x: make remote controller optional
Date: Wed, 02 Jan 2013 12:44:14 +0200 [thread overview]
Message-ID: <50E40F7E.6050707@iki.fi> (raw)
In-Reply-To: <CAOMZO5Ac_EAjzYkLec6ZOxvm4fpvvFr7pLyKYNz=8EhAFM+6Pw@mail.gmail.com>
On 01/02/2013 05:24 AM, Fabio Estevam wrote:
> On Sun, Dec 9, 2012 at 10:45 PM, Antti Palosaari <crope@iki.fi> wrote:
>> Do not compile remote controller when RC-core is disabled by Kconfig.
>>
>> Cc: Malcolm Priestley <tvboxspy@gmail.com>
>> Signed-off-by: Antti Palosaari <crope@iki.fi>
>> ---
>> drivers/media/usb/dvb-usb-v2/it913x.c | 36 +++++++++++++++++++----------------
>> 1 file changed, 20 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/media/usb/dvb-usb-v2/it913x.c b/drivers/media/usb/dvb-usb-v2/it913x.c
>> index 4720428..5dc352b 100644
>> --- a/drivers/media/usb/dvb-usb-v2/it913x.c
>> +++ b/drivers/media/usb/dvb-usb-v2/it913x.c
>> @@ -308,6 +308,7 @@ static struct i2c_algorithm it913x_i2c_algo = {
>> };
>>
>> /* Callbacks for DVB USB */
>> +#if defined(CONFIG_RC_CORE) || defined(CONFIG_RC_CORE_MODULE)
>
> Maybe you could use:
>
> #if IS_ENABLED(CONFIG_RC_CORE)
>
> Regards,
>
> Fabio Estevam
Thanks for the pointing that macro. I will sent new patch top of that
serie which replaces all "defined(CONFIG_RC_CORE) ||
defined(CONFIG_RC_CORE_MODULE)" with "IS_ENABLED(CONFIG_RC_CORE)" what I
added.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-01-02 10:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 0:45 [PATCH RFC 01/11] dvb_usb_v2: make remote controller optional Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 02/11] rtl28xxu: " Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 03/11] anysee: " Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 04/11] af9015: " Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 05/11] af9035: " Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 06/11] az6007: " Antti Palosaari
2012-12-10 17:22 ` Mauro Carvalho Chehab
2012-12-10 0:45 ` [PATCH RFC 07/11] it913x: " Antti Palosaari
2013-01-01 21:16 ` Antti Palosaari
2013-01-02 3:24 ` Fabio Estevam
2013-01-02 10:44 ` Antti Palosaari [this message]
2012-12-10 0:45 ` [PATCH RFC 08/11] it913x: remove unused define and increase module version Antti Palosaari
2012-12-10 19:02 ` Malcolm Priestley
2012-12-10 0:45 ` [PATCH RFC 09/11] dvb_usb_v2: remove rc-core stub implementations Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 10/11] dvb_usb_v2: use dummy function defines instead stub functions Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 11/11] dvb_usb_v2: change rc polling active/deactive logic Antti Palosaari
2013-01-06 12:11 ` [PATCH RFC 01/11] dvb_usb_v2: make remote controller optional Mauro Carvalho Chehab
2013-01-06 12:16 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E40F7E.6050707@iki.fi \
--to=crope@iki.fi \
--cc=festevam@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.