From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqPQT-0003D1-LG for qemu-devel@nongnu.org; Wed, 02 Jan 2013 09:36:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqP7K-0007Gc-Sv for qemu-devel@nongnu.org; Wed, 02 Jan 2013 09:17:05 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52544 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqP7K-0007Fz-KQ for qemu-devel@nongnu.org; Wed, 02 Jan 2013 09:16:26 -0500 Message-ID: <50E44132.1020309@suse.de> Date: Wed, 02 Jan 2013 15:16:18 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1355910821-21302-1-git-send-email-fred.konrad@greensocs.com> <1355910821-21302-2-git-send-email-fred.konrad@greensocs.com> <87obh7d6el.fsf@codemonkey.ws> In-Reply-To: <87obh7d6el.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowed field for the bus. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , fred.konrad@greensocs.com Cc: peter.maydell@linaro.org, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de, stefanha@redhat.com, cornelia.huck@de.ibm.com Am 02.01.2013 15:08, schrieb Anthony Liguori: > fred.konrad@greensocs.com writes: >=20 >> From: KONRAD Frederic >> >> Add a max_dev field to BusState to specify the maximum amount of devic= es allowed >> on the bus ( have no effect if max_dev=3D0 ) >> >> Signed-off-by: KONRAD Frederic >> --- >> hw/qdev-core.h | 2 ++ >> hw/qdev-monitor.c | 11 +++++++++++ >> 2 files changed, 13 insertions(+) >> >> diff --git a/hw/qdev-core.h b/hw/qdev-core.h >> index d672cca..af909b9 100644 >> --- a/hw/qdev-core.h >> +++ b/hw/qdev-core.h >> @@ -104,6 +104,8 @@ struct BusState { >> const char *name; >> int allow_hotplug; >> int max_index; >> + /* maximum devices allowed on the bus, 0 : no limit. */ >> + int max_dev; Can't for the virtio-bus case (which this is for AFAIU) the same effect be achieved by setting max_index? If not, this could use some more documentation - btw using gtk-doc style comments (above struct) would be a bonus. Regards, Andreas P.S. Please remember to use English punctuation rules, i.e. no spaces before colon or inside parenthesis. ;) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg