From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-la0-f44.google.com ([209.85.215.44]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TqTJQ-0006zc-3s for linux-mtd@lists.infradead.org; Wed, 02 Jan 2013 18:45:13 +0000 Received: by mail-la0-f44.google.com with SMTP id fr10so6638242lab.17 for ; Wed, 02 Jan 2013 10:45:08 -0800 (PST) Message-ID: <50E48DFD.2030908@mvista.com> Date: Wed, 02 Jan 2013 22:43:57 +0300 From: Sergei Shtylyov MIME-Version: 1.0 To: Heiko Schocher Subject: Re: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller References: <1343632944-25971-1-git-send-email-hs@denx.de> In-Reply-To: <1343632944-25971-1-git-send-email-hs@denx.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: davinci-linux-open-source@linux.davincidsp.com, devicetree-discuss@lists.ozlabs.org, Grant Likely , linux-mtd@lists.infradead.org, Scott Wood , David Woodhouse , linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello. On 07/30/2012 11:22 AM, Heiko Schocher wrote: > add OF support for the davinci nand controller. > Signed-off-by: Heiko Schocher > Cc: davinci-linux-open-source@linux.davincidsp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: devicetree-discuss@lists.ozlabs.org > Cc: linux-mtd@lists.infradead.org > Cc: David Woodhouse > Cc: Grant Likely > Cc: Sekhar Nori > Cc: Wolfgang Denk > Cc: Scott Wood [...] > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c > index d94b03c..f386b3c 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c [...] > @@ -518,9 +519,75 @@ static struct nand_ecclayout hwecc4_2048 __initconst = { > }, > }; > > +#if defined(CONFIG_OF) > +static const struct of_device_id davinci_nand_of_match[] = { > + {.compatible = "ti,davinci-nand", }, > + {}, > +} I have only one question: have you ever try to compile this patch with CONFIG_OF enabled? If you have, you would have noticed: drivers/mtd/nand/davinci_nand.c:527: error: expected ‘,’ or ‘;’ before ‘extern’ > +MODULE_DEVICE_TABLE(of, davinci_nand_of_match); No need to worry now, I'll send out the trivial patch... WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Wed, 02 Jan 2013 22:43:57 +0300 Subject: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller In-Reply-To: <1343632944-25971-1-git-send-email-hs@denx.de> References: <1343632944-25971-1-git-send-email-hs@denx.de> Message-ID: <50E48DFD.2030908@mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 07/30/2012 11:22 AM, Heiko Schocher wrote: > add OF support for the davinci nand controller. > Signed-off-by: Heiko Schocher > Cc: davinci-linux-open-source at linux.davincidsp.com > Cc: linux-arm-kernel at lists.infradead.org > Cc: devicetree-discuss at lists.ozlabs.org > Cc: linux-mtd at lists.infradead.org > Cc: David Woodhouse > Cc: Grant Likely > Cc: Sekhar Nori > Cc: Wolfgang Denk > Cc: Scott Wood [...] > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c > index d94b03c..f386b3c 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c [...] > @@ -518,9 +519,75 @@ static struct nand_ecclayout hwecc4_2048 __initconst = { > }, > }; > > +#if defined(CONFIG_OF) > +static const struct of_device_id davinci_nand_of_match[] = { > + {.compatible = "ti,davinci-nand", }, > + {}, > +} I have only one question: have you ever try to compile this patch with CONFIG_OF enabled? If you have, you would have noticed: drivers/mtd/nand/davinci_nand.c:527: error: expected ?,? or ?;? before ?extern? > +MODULE_DEVICE_TABLE(of, davinci_nand_of_match); No need to worry now, I'll send out the trivial patch... WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller Date: Wed, 02 Jan 2013 22:43:57 +0300 Message-ID: <50E48DFD.2030908@mvista.com> References: <1343632944-25971-1-git-send-email-hs@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1343632944-25971-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Heiko Schocher Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, Wolfgang Denk , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Scott Wood , David Woodhouse , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hello. On 07/30/2012 11:22 AM, Heiko Schocher wrote: > add OF support for the davinci nand controller. > Signed-off-by: Heiko Schocher > Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: David Woodhouse > Cc: Grant Likely > Cc: Sekhar Nori > Cc: Wolfgang Denk > Cc: Scott Wood [...] > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_n= and.c > index d94b03c..f386b3c 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c [...] > @@ -518,9 +519,75 @@ static struct nand_ecclayout hwecc4_2048 __initconst= =3D { > }, > }; > = > +#if defined(CONFIG_OF) > +static const struct of_device_id davinci_nand_of_match[] =3D { > + {.compatible =3D "ti,davinci-nand", }, > + {}, > +} I have only one question: have you ever try to compile this patch with CONFIG_OF enabled? If you have, you would have noticed: drivers/mtd/nand/davinci_nand.c:527: error: expected =91,=92 or =91;=92 bef= ore =91extern=92 > +MODULE_DEVICE_TABLE(of, davinci_nand_of_match); No need to worry now, I'll send out the trivial patch... WBR, Sergei