From: "Arend van Spriel" <arend@broadcom.com>
To: "Joe Perches" <joe@perches.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Linux Wireless List" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 08/18] brcmfmac: define pr_fmt in one place
Date: Wed, 2 Jan 2013 21:07:26 +0100 [thread overview]
Message-ID: <50E4937E.5000305@broadcom.com> (raw)
In-Reply-To: <1357149158.17061.45.camel@joe-AO722>
On 01/02/2013 06:52 PM, Joe Perches wrote:
> On Wed, 2013-01-02 at 15:22 +0100, Arend van Spriel wrote:
>> Several source files (but not all) define the pr_fmt() macro in exactly
>> the same way. Instead this commit defines it in a header file so driver
>> logging is consistent.
>
> The commit message doesn't describe the change to brcm_err
Thanks, Joe
I actually did not intend to change that. The net_ratelimit stuff should
stay.
John,
I will resubmit this patch.
Gr. AvS
>> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h b/drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h
> []
>> @@ -34,19 +34,12 @@
>> #define BRCMF_SCAN_VAL 0x4000
>> #define BRCMF_CONN_VAL 0x8000
>>
>> -/* Macro for error messages. net_ratelimit() is used when driver
>> - * debugging is not selected. When debugging the driver error
>> - * messages are as important as other tracing or even more so.
>> - */
>> -#ifdef CONFIG_BRCMDBG
>> +/* set default print format */
>> +#undef pr_fmt
>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>> +
>> +/* error messages are always logged */
>> #define brcmf_err(fmt, ...) pr_err("%s: " fmt, __func__, ##__VA_ARGS__)
>> -#else
>> -#define brcmf_err(fmt, ...) \
>> - do { \
>> - if (net_ratelimit()) \
>> - pr_err("%s: " fmt, __func__, ##__VA_ARGS__); \
>> - } while (0)
>> -#endif
>
>
>
next prev parent reply other threads:[~2013-01-02 20:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 14:22 [PATCH 00/18] brcm80211: cleanup work Arend van Spriel
2013-01-02 14:22 ` [PATCH 01/18] brcmsmac: increase timer reference count for new timers only Arend van Spriel
2013-01-02 14:22 ` [PATCH 02/18] brcmsmac: use perimeter lock in add_interface() callback Arend van Spriel
2013-01-02 14:22 ` [PATCH 03/18] brcmsmac: allow user-space setting of interface address Arend van Spriel
2013-01-02 14:22 ` [PATCH 04/18] brcmsmac: remove dead code Arend van Spriel
2013-01-02 14:22 ` [PATCH 05/18] brcmfmac: do not reconfigure refill rx on 0-length packet Arend van Spriel
2013-01-02 14:22 ` [PATCH 06/18] brcmfmac: removed deprecated set_bitrate_mask support Arend van Spriel
2013-01-02 14:22 ` [PATCH 07/18] brcmfmac: assure USB dongle firmware is reset upon module unload Arend van Spriel
2013-01-02 14:22 ` [PATCH 08/18] brcmfmac: define pr_fmt in one place Arend van Spriel
2013-01-02 17:52 ` Joe Perches
2013-01-02 20:07 ` Arend van Spriel [this message]
2013-01-02 20:20 ` [PATCH v2 " Arend van Spriel
2013-01-02 20:34 ` Joe Perches
2013-01-02 20:52 ` Arend van Spriel
2013-01-02 14:22 ` [PATCH 09/18] brcmfmac: remove rx helper function from bus interface Arend van Spriel
2013-01-02 14:22 ` [PATCH 10/18] brcmfmac: remove brcmf_proto_hdrpull() " Arend van Spriel
2013-01-02 14:22 ` [PATCH 11/18] brcmfmac: Use dedicated trace level for CDC Arend van Spriel
2013-01-02 14:22 ` [PATCH 12/18] brcmfmac: remove unused event related definitions Arend van Spriel
2013-01-02 14:22 ` [PATCH 13/18] brcmfmac: cleanup netdev transmit callback Arend van Spriel
2013-01-02 14:22 ` [PATCH 14/18] brcmfmac: remove unnecessary curly braces in dhd_attach() Arend van Spriel
2013-01-02 14:22 ` [PATCH 15/18] brcmfmac: Remove unused caching dongle error Arend van Spriel
2013-01-02 14:22 ` [PATCH 16/18] brcmfmac: Return correct error on netdev xmit Arend van Spriel
2013-01-02 14:22 ` [PATCH 17/18] brcmfmac: Removing obsolete variables and inline functions Arend van Spriel
2013-01-02 14:22 ` [PATCH 18/18] brcmfmac: Update init code routines from interface up Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E4937E.5000305@broadcom.com \
--to=arend@broadcom.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.