All of lore.kernel.org
 help / color / mirror / Atom feed
From: Malcolm Crossley <malcolm.crossley@citrix.com>
To: Ben Guthro <ben@guthro.net>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: S3 resume issues
Date: Wed, 2 Jan 2013 20:35:18 +0000	[thread overview]
Message-ID: <50E49A06.4010504@citrix.com> (raw)
In-Reply-To: <CAOvdn6Xqz42VwgGN9E+FOM+AyCSLDEN+0OXue855EM0ib4M5Aw@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1302 bytes --]

On 02/01/13 16:46, Ben Guthro wrote:
> On Wed, Jan 2, 2013 at 10:31 AM, Ben Guthro <ben@guthro.net 
> <mailto:ben@guthro.net>> wrote:
>
>         The actual wakeup vector is wakeup_start in
>         xen/arch/x86/boot/wakeup.S
>
>
>     I'll take a look at this, thanks for the pointer.
>
>
> I've tried putting a "ud2" instruction at the start of wakeup_start - 
> and the machine doesn't seem to crash.
> I also tried a divide by zero in the same place, just for good measure.
>
> It would appear that this wakeup_start is not getting executed on resume.
> Presumably, the BIOS is causing the disk, and CDROM LEDs to flash, 
> while enumerating the bus.
>
> A difference between Xen 4.0.y and 4.2.y seems to be the removal of 
> the boot trampoline fixed address, that much of this is calculated as 
> an offset of.
> Could an error in this path cause such a behavior?

It seems the trampoline is allocated at a different location in Xen 4.2 
(EBDA - 64k instead of 0x7c000). I have attached a quick patch to move 
the location back to 0x7c000 to see if that helps your system. I have 
compile and boot tested the patch but not had time to do a S3 test on 
it. Can you try it on your system?

Can you also run the following command as root in dom0:

hexdump -s 0x400 -n 32 /dev/mem
>
> /btg

Malcolm

[-- Attachment #1.2: Type: text/html, Size: 2596 bytes --]

[-- Attachment #2: force-x86-trampoline-to-0x7c000.patch --]
[-- Type: text/x-patch, Size: 733 bytes --]

# HG changeset patch
# Parent a98b2e22ecbb57fee6b061dee3e3fb264fbf6f4e
Test patch!: Force x86 boot trampoline to be allocated at 0x7c000 instead of EBDA - 64k

diff -r a98b2e22ecbb xen/arch/x86/boot/head.S
--- a/xen/arch/x86/boot/head.S
+++ b/xen/arch/x86/boot/head.S
@@ -77,8 +77,8 @@ gdt_boot_descr:
         cmp     $0x2BADB002,%eax
         jne     not_multiboot
 
-        /* Set up trampoline segment 64k below EBDA */
-        movzwl  0x40e,%eax          /* EBDA segment */
+        /* Hard code trampoline to 0x7c000 */
+        mov     $0x8c00,%eax        /* hardcoded 0x8c00 */
         cmp     $0xa000,%eax        /* sanity check (high) */
         jae     0f
         cmp     $0x4000,%eax        /* sanity check (low) */

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-01-02 20:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-02 13:08 S3 resume issues Ben Guthro
2013-01-02 15:15 ` Malcolm Crossley
2013-01-02 15:31   ` Ben Guthro
2013-01-02 16:46     ` Ben Guthro
2013-01-02 20:35       ` Malcolm Crossley [this message]
2013-01-02 20:50         ` Ben Guthro
2013-01-03 10:19       ` Jan Beulich
2013-01-03 16:33         ` Ben Guthro
2013-01-03 17:08           ` Jan Beulich
2013-01-03 17:28             ` Ben Guthro
2013-01-03 21:26               ` Ben Guthro
2013-01-04  8:34                 ` Jan Beulich
2013-01-11 20:32                   ` Ben Guthro
2013-01-14 22:00                     ` Ben Guthro
2013-01-15  8:33                       ` Jan Beulich
2013-01-15 12:55                         ` Ben Guthro
2013-01-15 18:10                           ` Ben Guthro
2013-01-15 18:17                             ` Malcolm Crossley
2013-01-15 18:22                               ` Ben Guthro
2013-01-15 18:32                                 ` Malcolm Crossley
2013-01-15 18:38                                   ` Ben Guthro
2013-01-15 18:39                                     ` Malcolm Crossley
2013-01-16 16:16                                       ` Ben Guthro
2013-01-16  9:35                             ` Jan Beulich
     [not found]                               ` <CAOvdn6V6N1V9ZYbARTJPEgSvxPe83pSiO6TmxBLy1LJEkods6A@mail.gmail.com>
2013-01-16 10:57                                 ` Jan Beulich
2013-01-16 11:05                                   ` Ben Guthro
2013-01-16 11:09                                     ` Jan Beulich
2013-01-16 11:17                                       ` Ben Guthro
2013-01-02 17:14     ` Pasi Kärkkäinen
2013-01-02 17:20       ` Ben Guthro
2013-01-16  2:18 ` Tomasz Wroblewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E49A06.4010504@citrix.com \
    --to=malcolm.crossley@citrix.com \
    --cc=ben@guthro.net \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.