From: Johannes Sixt <j6t@kdbg.org>
To: "Grégory Pakosz" <gpakosz@visionobjects.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: git filter-branch doesn't dereference annotated tags
Date: Thu, 03 Jan 2013 11:33:56 +0100 [thread overview]
Message-ID: <50E55E94.2090401@kdbg.org> (raw)
In-Reply-To: <CAC_01E2HXSnXBgDm=Cbwgi5PbiuHp_qPpoaqT_=pdDWDMnC5jA@mail.gmail.com>
Am 03.01.2013 10:50, schrieb Grégory Pakosz:
>>
>> IOW, if the command was something like
>>
>> git filter-branch ...filter options... -- v1.0 master ...
>>
>> and v1.0 is an annotated tag, then it is reasonable to expect v1.0 to be
>> deleted if the commit it points to goes away. But if the commit did not
>> go away, but was rewritten, then it is equally reasonable to expect that
>> the tag is also rewritten. But I don't think that we currently do the
>> latter.
>>
> When the commit doesn't go away, the tag is currently being rewritten properly.
Indeed, but only if a --tag-name-filter was specified.
>> Therefore, IMO, a change that implements the former behavior should also
>> implement the latter behavior.
>>
> The patch in my latest email does both. (yet lacks unit tests for now)
If it deletes a tag only when --tag-name-filter was specified, than that
should be fine.
-- Hannes
next prev parent reply other threads:[~2013-01-03 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 16:24 git filter-branch doesn't dereference annotated tags Grégory Pakosz
2012-12-31 18:31 ` Junio C Hamano
2013-01-01 13:11 ` Grégory Pakosz
2013-01-01 19:49 ` Junio C Hamano
2013-01-01 20:20 ` Grégory Pakosz
2013-01-01 21:04 ` Junio C Hamano
2013-01-02 22:03 ` Grégory Pakosz
2013-01-02 23:19 ` Junio C Hamano
2013-01-03 9:38 ` Johannes Sixt
2013-01-03 9:50 ` Grégory Pakosz
2013-01-03 10:33 ` Johannes Sixt [this message]
2013-01-03 20:52 ` Brandon Casey
2013-01-01 12:30 ` Johannes Sixt
-- strict thread matches above, loose matches on Subject: below --
2012-12-31 14:36 Grégory Pakosz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E55E94.2090401@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gpakosz@visionobjects.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.