From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-la0-f41.google.com ([209.85.215.41]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tqj8k-0007GG-BH for linux-mtd@lists.infradead.org; Thu, 03 Jan 2013 11:39:15 +0000 Received: by mail-la0-f41.google.com with SMTP id em20so7733624lab.28 for ; Thu, 03 Jan 2013 03:39:11 -0800 (PST) Message-ID: <50E56DDC.8060804@mvista.com> Date: Thu, 03 Jan 2013 15:39:08 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: David Woodhouse Subject: Re: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller References: <1343632944-25971-1-git-send-email-hs@denx.de> <50E48DFD.2030908@mvista.com> <50E52D26.9010004@denx.de> <50E56AED.1000509@mvista.com> <1357212752.16197.127.camel@shinybook.infradead.org> In-Reply-To: <1357212752.16197.127.camel@shinybook.infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: davinci-linux-open-source@linux.davincidsp.com, devicetree-discuss@lists.ozlabs.org, Grant Likely , linux-mtd@lists.infradead.org, Scott Wood , hs@denx.de, linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello. On 03-01-2013 15:32, David Woodhouse wrote: >>>>> +#if defined(CONFIG_OF) >>>>> +static const struct of_device_id davinci_nand_of_match[] = { >>>>> + {.compatible = "ti,davinci-nand", }, >>>>> + {}, >>>>> +} >>>>> +MODULE_DEVICE_TABLE(of, davinci_nand_of_match); >>> Hmm.. maybe this crept in later after I sent the patches? They were >>> pending for a while ... I compiled it just yet again (based on my >>> tree when I posted this patch based on commit: >> I've just checked the archives: every patch version you posted had ';' >> after '}' missing. > If it was built-in, rather than as a module, then MODULE_DEVICE_TABLE(…) > expands to nothing, and the structure gets to use the semicolon from the > end of that line. Ah, that explains it: 'davinci_all_defconfig' has CONFIG_MTD_NAND_DAVINCI=m, so that's how the error got triggered at last. Probably worth adding this explanation to the changelog, how do you think? WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Thu, 03 Jan 2013 15:39:08 +0400 Subject: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller In-Reply-To: <1357212752.16197.127.camel@shinybook.infradead.org> References: <1343632944-25971-1-git-send-email-hs@denx.de> <50E48DFD.2030908@mvista.com> <50E52D26.9010004@denx.de> <50E56AED.1000509@mvista.com> <1357212752.16197.127.camel@shinybook.infradead.org> Message-ID: <50E56DDC.8060804@mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 03-01-2013 15:32, David Woodhouse wrote: >>>>> +#if defined(CONFIG_OF) >>>>> +static const struct of_device_id davinci_nand_of_match[] = { >>>>> + {.compatible = "ti,davinci-nand", }, >>>>> + {}, >>>>> +} >>>>> +MODULE_DEVICE_TABLE(of, davinci_nand_of_match); >>> Hmm.. maybe this crept in later after I sent the patches? They were >>> pending for a while ... I compiled it just yet again (based on my >>> tree when I posted this patch based on commit: >> I've just checked the archives: every patch version you posted had ';' >> after '}' missing. > If it was built-in, rather than as a module, then MODULE_DEVICE_TABLE(?) > expands to nothing, and the structure gets to use the semicolon from the > end of that line. Ah, that explains it: 'davinci_all_defconfig' has CONFIG_MTD_NAND_DAVINCI=m, so that's how the error got triggered at last. Probably worth adding this explanation to the changelog, how do you think? WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller Date: Thu, 03 Jan 2013 15:39:08 +0400 Message-ID: <50E56DDC.8060804@mvista.com> References: <1343632944-25971-1-git-send-email-hs@denx.de> <50E48DFD.2030908@mvista.com> <50E52D26.9010004@denx.de> <50E56AED.1000509@mvista.com> <1357212752.16197.127.camel@shinybook.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1357212752.16197.127.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: David Woodhouse Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, Wolfgang Denk , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Scott Wood , hs-ynQEQJNshbs@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org SGVsbG8uCgpPbiAwMy0wMS0yMDEzIDE1OjMyLCBEYXZpZCBXb29kaG91c2Ugd3JvdGU6Cgo+Pj4+ PiArI2lmIGRlZmluZWQoQ09ORklHX09GKQo+Pj4+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9k ZXZpY2VfaWQgZGF2aW5jaV9uYW5kX29mX21hdGNoW10gPSB7Cj4+Pj4+ICsgICAgey5jb21wYXRp YmxlID0gInRpLGRhdmluY2ktbmFuZCIsIH0sCj4+Pj4+ICsgICAge30sCj4+Pj4+ICt9Cj4+Pj4+ ICtNT0RVTEVfREVWSUNFX1RBQkxFKG9mLCBkYXZpbmNpX25hbmRfb2ZfbWF0Y2gpOwoKPj4+IEht bS4uIG1heWJlIHRoaXMgY3JlcHQgaW4gbGF0ZXIgYWZ0ZXIgSSBzZW50IHRoZSBwYXRjaGVzPyBU aGV5IHdlcmUKPj4+IHBlbmRpbmcgZm9yIGEgd2hpbGUgLi4uIEkgY29tcGlsZWQgaXQganVzdCB5 ZXQgYWdhaW4gKGJhc2VkIG9uIG15Cj4+PiB0cmVlIHdoZW4gSSBwb3N0ZWQgdGhpcyBwYXRjaCBi YXNlZCBvbiBjb21taXQ6Cgo+PiAgICAgIEkndmUganVzdCBjaGVja2VkIHRoZSBhcmNoaXZlczog ZXZlcnkgcGF0Y2ggdmVyc2lvbiB5b3UgcG9zdGVkIGhhZCAnOycKPj4gYWZ0ZXIgJ30nIG1pc3Np bmcuCgo+IElmIGl0IHdhcyBidWlsdC1pbiwgcmF0aGVyIHRoYW4gYXMgYSBtb2R1bGUsIHRoZW4g TU9EVUxFX0RFVklDRV9UQUJMRSjigKYpCj4gZXhwYW5kcyB0byBub3RoaW5nLCBhbmQgdGhlIHN0 cnVjdHVyZSBnZXRzIHRvIHVzZSB0aGUgc2VtaWNvbG9uIGZyb20gdGhlCj4gZW5kIG9mIHRoYXQg bGluZS4KCiAgICBBaCwgdGhhdCBleHBsYWlucyBpdDogJ2RhdmluY2lfYWxsX2RlZmNvbmZpZycg aGFzIApDT05GSUdfTVREX05BTkRfREFWSU5DST1tLCBzbyB0aGF0J3MgaG93IHRoZSBlcnJvciBn b3QgdHJpZ2dlcmVkIGF0IGxhc3QuIApQcm9iYWJseSB3b3J0aCBhZGRpbmcgdGhpcyBleHBsYW5h dGlvbiB0byB0aGUgY2hhbmdlbG9nLCBob3cgZG8geW91IHRoaW5rPwoKV0JSLCBTZXJnZWkKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmljZXRyZWUt ZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNldHJlZS1kaXNjdXNzQGxpc3RzLm96bGFicy5vcmcK aHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2RldmljZXRyZWUtZGlzY3Vzcwo=