All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx53loco: Fix PMIC name
Date: Thu, 03 Jan 2013 15:02:30 +0100	[thread overview]
Message-ID: <50E58F76.2080505@denx.de> (raw)
In-Reply-To: <CAOMZO5DZs_eYXpm37uCRWLs_AWU1mWjjSZMM0xu8KghCdQhFBw@mail.gmail.com>

On 03/01/2013 14:25, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Thu, Jan 3, 2013 at 6:53 AM, Stefano Babic <sbabic@denx.de> wrote:
> 
>> Hi all,
>>
>> the patch was only blocked for Wolfgang's comment regarding the
>> introduced ALIGN() macro. I think the other doubts regarding issues on
>> other Socs (i.e., MX6) can be considered closed as well. IMHO it is
>> enough to rename the macro to ROUND_UP (as Troy have already proposed),
>> and then I will apply to i.MX tree.
> 
> I tried using DIV_ROUND_UP definition from common.h and the board does not boot.
> 
> I rename it to ROUND, which matches the definition in common.h.

I agree with this solution - I do not like that common.h is included,
because _config must run and tools should be independent from the
selected board.


> 
> Just sent the patch.

Then I apply it !

Thanks,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      parent reply	other threads:[~2013-01-03 14:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 16:36 [U-Boot] [PATCH] mx53loco: Fix PMIC name Fabio Estevam
2012-12-13  8:25 ` Stefano Babic
2012-12-20 22:04 ` Robert Nelson
2012-12-22 12:51   ` Fabio Estevam
2012-12-26 15:02   ` Fabio Estevam
2012-12-26 15:07     ` Fabio Estevam
2012-12-26 15:21       ` Fabio Estevam
2012-12-26 15:51         ` Robert Nelson
2012-12-26 15:54           ` Fabio Estevam
2012-12-26 16:04             ` Robert Nelson
2012-12-26 16:50               ` Fabio Estevam
2012-12-26 17:08                 ` Robert Nelson
2012-12-26 17:21                   ` Fabio Estevam
2012-12-26 17:51                     ` Robert Nelson
2013-01-02 18:27                       ` Robert Nelson
2013-01-02 18:33                         ` Fabio Estevam
2013-01-02 19:42                           ` Troy Kisky
2013-01-02 19:58                             ` Robert Nelson
2013-01-02 20:02                               ` Fabio Estevam
2013-01-03  8:53                                 ` Stefano Babic
2013-01-03 13:25                                   ` Fabio Estevam
2013-01-03 13:30                                     ` Marek Vasut
2013-01-03 13:35                                       ` Fabio Estevam
2013-01-03 13:49                                         ` Marek Vasut
2013-01-03 14:07                                           ` Stefano Babic
2013-01-03 18:18                                             ` Troy Kisky
2013-01-03 18:26                                               ` Fabio Estevam
2013-01-03 14:30                                           ` Fabio Estevam
2013-01-03 14:02                                     ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E58F76.2080505@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.