Re: [Qemu-devel] [PATCH 03/11] qemu-img: remove parameter filename in collect_image_info()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

On 12/29/2012 01:45 AM, Wenchao Xia wrote:
>   Switch the filename getting from parameter to block function,
> now collect_image_info depends only on *bs.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  qemu-img.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 5a4df3a..d70435f 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -1180,15 +1180,17 @@ static void dump_json_image_info(ImageInfo *info)
>      QDECREF(str);
>  }
>  
> +/* Assume bs is already openned. */

s/openned/opened/

Once that is fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]