From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1TqqXC-0005yo-QE for mharc-grub-devel@gnu.org; Thu, 03 Jan 2013 14:32:58 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqqXA-0005xt-BR for grub-devel@gnu.org; Thu, 03 Jan 2013 14:32:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqqX9-0002Ok-2m for grub-devel@gnu.org; Thu, 03 Jan 2013 14:32:56 -0500 Received: from mail-ee0-f41.google.com ([74.125.83.41]:59961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqqX8-0002Od-Su for grub-devel@gnu.org; Thu, 03 Jan 2013 14:32:55 -0500 Received: by mail-ee0-f41.google.com with SMTP id d41so7516159eek.14 for ; Thu, 03 Jan 2013 11:32:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type; bh=pPBI43ulD2y5js7Q5IH21uTxBiynGxZUKJEH3v1RAeg=; b=mDOv+sLlevnpv26ZFrHsxIL1pJgv/tOnB+78xu0+33AEmLDbb32zvI8mKw/fux/YFH AyCRsivDgPbE6Hc0cwsZdkVj9QVT3UgoMN2R4oCGvnwcznce86RuEKGAIbZMekkgZ2L2 rezjX/naO5i46mhXupiwdWBGyljUF7hmo2YkfeuvxK/kvAxSMiDX5JBUnn+LLuCMimXH zoSFwmGDTH7aJS8lLQBTHBXEU4zKcWYIlEH0i+FufTvrti8YXSe+GS1JzJAg8a3XddMo 25rUCujQSrC4FPjYbpX455tonRZ9VelLSfjVitwRxN57Z77IhAF5Ir0R05zBu0zAu9DN Ujhw== X-Received: by 10.14.1.195 with SMTP id 43mr136847468eed.31.1357241574061; Thu, 03 Jan 2013 11:32:54 -0800 (PST) Received: from debian.x201.phnet (54-133.79-83.cust.bluewin.ch. [83.79.133.54]) by mx.google.com with ESMTPS id 44sm105790931eek.0.2013.01.03.11.32.52 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Jan 2013 11:32:52 -0800 (PST) Message-ID: <50E5DCE2.6000608@gmail.com> Date: Thu, 03 Jan 2013 20:32:50 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121122 Icedove/10.0.11 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] Removing nested functions, part one of lots References: <20130101144204.GZ21216@riva.dynamic.greenend.org.uk> In-Reply-To: <20130101144204.GZ21216@riva.dynamic.greenend.org.uk> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigE5A144DE1999D9DB44A0311B" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2013 19:32:57 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE5A144DE1999D9DB44A0311B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01.01.2013 15:42, Colin Watson wrote: > I have a number of patches mostly ready to go, but I'd prefer to make > sure that this general approach is agreed before preparing and sending > more than one of them. I'd like to work one *_iterate function at a > time (except where multiple iterators are entangled in a stack such tha= t > we need to change several at once, as is the case in parts of the > disk/filesystem stacks), as that's roughly the minimum sensible unit an= d > it makes it reasonably easy to grep for missing changes. There is also another approach of using iterators of the kind: struct pci_iterator; void pci_init (struct pci_iterator *pci); int pci_iter (struct pci_iterator *pci); #define FOR_PCI_DEVICE(x) for (pci_init (&x); pci_iter (&x);) I have done it for PCI but seem to have bzr problem: bzr: ERROR: Revision {phcoder@gmail.com-20110421142803-h6jncda1j0lf8msf} not present in "Graph(StackedParentsProvider(bzrlib.repository._LazyListJoin(([CachingPa= rentsProvider(CallableToParentsProviderAdapter())], []))))". Admittingly for disk/filesystems it's not viable and even for PCI it was somewhat messy but may be viable in some cases like where we already switch to FOR_* macros. >=20 > Please review. >=20 > Thanks, >=20 >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigE5A144DE1999D9DB44A0311B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlDl3OIACgkQNak7dOguQgkRPwEAgI0ikI/0CXJhm4UpoXY80zDe U4tdU/CLd+IcV6RB3QgA/i/oZ5Czb2h7Sn+6NFQTLbgpSjUVxbm/vmLWYfvR/nyG =gsct -----END PGP SIGNATURE----- --------------enigE5A144DE1999D9DB44A0311B--