From: Chen Gang <gang.chen@asianux.com>
To: Jan Kara <jack@suse.cz>
Cc: Theodore Ts'o <tytso@mit.edu>,
akpm@linux-foundation.org, linux-ext4@vger.kernel.org
Subject: Re: [Suggestion] fs/ext3: memory leak by calling set_qf_name or clear_qf_name, many times.
Date: Fri, 04 Jan 2013 13:39:37 +0800 [thread overview]
Message-ID: <50E66B19.5060907@asianux.com> (raw)
In-Reply-To: <20121231120621.GD7564@quack.suse.cz>
于 2012年12月31日 20:06, Jan Kara 写道:
> Thanks for report. Yes, memory leak seems to be possible. Attached patch
> should fix it, I have added it to my tree.
>
> Honza
>
after read your patch, today (although I am not a reviewer).
is it a possible situation like this (just my imagination):
1st let it call clear_qf_name successfully.
2nd let it call set_qf_name successfully.
3rd call clear_qf_name again ?
...
if this situation is possible.
I guess the memory still leak, after apply your patch.
if what I guess is true
it seems we have to duplicate memory for old_opts in ext3_remount.
and for clear_qf_name, set_qf_name, ext3_remount:
use normal memory allocation and free ways instead of current using.
Regards
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-04 5:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 5:04 [Suggestion] fs/ext3: memory leak by calling set_qf_name or clear_qf_name, many times Chen Gang
2012-12-27 8:06 ` Chen Gang
2012-12-31 12:06 ` Jan Kara
2013-01-04 5:39 ` Chen Gang [this message]
2013-01-07 19:54 ` Jan Kara
2013-01-08 3:13 ` Chen Gang
2013-01-14 2:29 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E66B19.5060907@asianux.com \
--to=gang.chen@asianux.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.