From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: Kirkwood issues with 3.8-rc1 - Ooops and hang on reboot
Date: Fri, 04 Jan 2013 08:38:08 +0100 [thread overview]
Message-ID: <50E686E0.5010001@lunn.ch> (raw)
In-Reply-To: <CAMW5UfbvwVgBiDQxSEJ5+rg4ZL1mCxTQ_xgcZL-8rTZCf3uV4w@mail.gmail.com>
On 04/01/13 00:26, Josh Coombs wrote:
> I did a test build with the __init tag removed (which is not the
> correct answer) and everything works. GPIO is functional (I didn't
> catch the power LED wasn't working prior), I don't get a panic, and I
> can now reboot cleanly as well. So that confirms the basic diagnosis.
>
> I've been trying to wrap my head around include/linux/init.h to see
> what the correct tagging should be but I'll admit, I'm in over my head
> so far. If anyone has suggested reading on the topic I'd be very
> appreciative.
Hi Josh
The question is, when can this function be used? Only during boot time?
Or at any time? For functions which are only used during boot, __init is
O.K. However, since modules can also want to use clks, we need to be
able to look up clocks at any time. So this function needs to be around
all the time, which is the default behavior of no tag.
Andrew
next prev parent reply other threads:[~2013-01-04 7:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 17:17 Kirkwood issues with 3.8-rc1 - Ooops and hang on reboot Andrew Lunn
2012-12-28 17:38 ` Russell King - ARM Linux
2012-12-29 23:31 ` Josh Coombs
2012-12-30 0:23 ` Russell King - ARM Linux
2013-01-03 4:50 ` Josh Coombs
2013-01-03 8:22 ` Andrew Lunn
2013-01-03 23:26 ` Josh Coombs
2013-01-04 7:38 ` Andrew Lunn [this message]
2012-12-28 18:19 ` Josh Coombs
-- strict thread matches above, loose matches on Subject: below --
2012-12-28 16:09 Josh Coombs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E686E0.5010001@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.