From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TrCPV-00075s-2b for qemu-devel@nongnu.org; Fri, 04 Jan 2013 13:54:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TrCPR-0005G1-8v for qemu-devel@nongnu.org; Fri, 04 Jan 2013 13:54:28 -0500 Received: from mail-ia0-f180.google.com ([209.85.210.180]:53652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TrCPR-0005Fq-4F for qemu-devel@nongnu.org; Fri, 04 Jan 2013 13:54:25 -0500 Received: by mail-ia0-f180.google.com with SMTP id t4so13838773iag.39 for ; Fri, 04 Jan 2013 10:54:24 -0800 (PST) Sender: Richard Henderson Message-ID: <50E7255E.9020405@twiddle.net> Date: Fri, 04 Jan 2013 10:54:22 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1357268368-3692-1-git-send-email-dillona@dillona.com> In-Reply-To: <1357268368-3692-1-git-send-email-dillona@dillona.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] linux-user: Add support for oldumount List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: dillona@dillona.com Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org On 01/03/2013 06:59 PM, dillona@dillona.com wrote: > From: Dillon Amburgey > > This is used at least on the Alpha architecture > > Signed-off-by: Dillon Amburgey > --- > linux-user/syscall.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index e99adab..0cd54f3 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -5497,6 +5497,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, > unlock_user(p3, arg3, 0); > break; > } > +#ifdef TARGET_NR_oldumount > + case TARGET_NR_oldumount: > + if (!(p = lock_user_string(arg1))) > + goto efault; > + ret = get_errno(umount(p)); > + unlock_user(p, arg1, 0); > + break; > +#endif It's probably better to rename the Alpha TARGET_NR_{oldumount,umount} syscall names to TARGET_NR_{umount,umount2}. Regardless of what the names the kernel uses for these, it's the mapping to the implementations in the syscall tables that matters. r~