From: Richard Henderson <rth@twiddle.net>
To: Nickolai Zeldovich <nickolai@csail.mit.edu>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: fix copy_to_user_fdset for fds over 30
Date: Fri, 04 Jan 2013 10:57:07 -0800 [thread overview]
Message-ID: <50E72603.5080607@twiddle.net> (raw)
In-Reply-To: <1357207368-21116-1-git-send-email-nickolai@csail.mit.edu>
On 01/03/2013 02:02 AM, Nickolai Zeldovich wrote:
> - v |= ((FD_ISSET(k, fds) != 0) << j);
> + v |= (((abi_ulong) (FD_ISSET(k, fds) != 0)) << j);
It would be easier to read if you dropped the unnecessary parens.
v |= (abi_ulong)(FD_ISSET(k, fds) != 0) << j;
Otherwise the change looks correct.
r~
prev parent reply other threads:[~2013-01-04 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 10:02 [Qemu-devel] [PATCH] linux-user/syscall.c: fix copy_to_user_fdset for fds over 30 Nickolai Zeldovich
2013-01-04 18:57 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E72603.5080607@twiddle.net \
--to=rth@twiddle.net \
--cc=nickolai@csail.mit.edu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.